Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #126 #127

Merged
merged 1 commit into from
Aug 25, 2024
Merged

Fixes #126 #127

merged 1 commit into from
Aug 25, 2024

Conversation

ogarcia
Copy link
Collaborator

@ogarcia ogarcia commented Aug 25, 2024

The startup script attempts to create the identity.secret file before the ${CONFIG_PATH} directory containing the identity.secret file. This change fixes that problem and makes sure to create that directory first.

The startup script attempts to create the identity.secret file before
the ${CONFIG_PATH} directory containing the identity.secret file. This
change fixes that problem and makes sure to create that directory first.
@ogarcia
Copy link
Collaborator Author

ogarcia commented Aug 25, 2024

@mwarning as soon as possible send this change to the merge request openwrt/packages#24773

The truth is that I did not notice the failure because all the tests I did was with the router already started doing restarts of the daemon, but if you start from scratch the creation of the directory happens after trying to put the secret file inside it and, of course, it does not work. Simply changing the order of how things happen will solve the problem.

@mwarning mwarning merged commit ddf9b49 into master Aug 25, 2024
@ogarcia ogarcia deleted the init-fix branch August 26, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants