Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate LSST schemas and enhance Alert for Pitt-Google-Broker/pull/263 #81

Merged
merged 25 commits into from
Mar 17, 2025

Conversation

troyraen
Copy link
Contributor

@troyraen troyraen commented Mar 11, 2025

Closes #72.

Copy link

codacy-production bot commented Mar 11, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+2.01% 96.25%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (7c91733) 829 536 64.66%
Head commit (bda9398) 858 (+29) 572 (+36) 66.67% (+2.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#81) 80 77 96.25%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@troyraen troyraen force-pushed the issues/72/version-agnostic-lsst-schema branch from d48a16d to 7373ab5 Compare March 11, 2025 09:15
@troyraen troyraen force-pushed the issues/72/version-agnostic-lsst-schema branch 3 times, most recently from 611691f to 298fbee Compare March 12, 2025 05:11
@troyraen troyraen requested a review from hernandezc1 March 12, 2025 05:58
@troyraen troyraen force-pushed the issues/72/version-agnostic-lsst-schema branch 2 times, most recently from 17f5ecc to 7ca9d1c Compare March 16, 2025 16:44
@troyraen troyraen added the enhancement New feature or request label Mar 16, 2025
@troyraen troyraen force-pushed the issues/72/version-agnostic-lsst-schema branch from 7ca9d1c to b784981 Compare March 16, 2025 23:07
@troyraen troyraen force-pushed the issues/72/version-agnostic-lsst-schema branch from cc3541e to bda9398 Compare March 16, 2025 23:49
@troyraen
Copy link
Contributor Author

@hernandezc1 I'm going to go ahead and merge this because I want to do a more major refactor of the schemas in a fresh PR that is based on these changes. I could leave this open and still do that, but I don't want to make any more changes in this PR anyway because of the high potential for conflicts. If this PR needs changes, I'll make them in a followup.

@troyraen troyraen changed the title Refactor lsst_schema_helper to get version from avro header Consolidate LSST schemas and enhance Alert for Pitt-Google-Broker/pull/263 Mar 17, 2025
@troyraen troyraen merged commit ae13727 into main Mar 17, 2025
10 of 11 checks passed
@troyraen troyraen deleted the issues/72/version-agnostic-lsst-schema branch March 17, 2025 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor the LSST schema helper so the user does not need to know the schema version
1 participant