-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup and config change for GPhL-specific file #13
Open
rhfogh
wants to merge
38
commits into
mxcube:master
Choose a base branch
from
rhfogh:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
e0af92f
Fixes to mock-test GSK stratcal run
rhfogh 2f2892c
GPhL configuration updates, various
rhfogh 695c2f8
Cleanup. Also removed queue_model_objects_v1 reference
rhfogh f2e8d75
Changed to reflect new location of configuration files
rhfogh edff34d
Finished merging ALBA_gphl 2.3.0 into master.
rhfogh 1dd8ed6
Cleaned up imports, and bug fixes in latest merge
rhfogh aca27c2
Fixes to mock-test GSK stratcal run
rhfogh 7808516
GPhL configuration updates, various
rhfogh 5922b7e
Cleanup. Also removed queue_model_objects_v1 reference
rhfogh caebe76
Changed to reflect new location of configuration files
rhfogh b6ecf53
Finished merging ALBA_gphl 2.3.0 into master.
rhfogh 6799fae
Cleaned up imports, and bug fixes in latest merge
rhfogh c0a6732
Merge remote-tracking branch 'rhfogh/master' into rhfogh
rhfogh 63bf3ca
Fixed comment spelling
rhfogh 45ef007
UI and HO changes prior tio ALBA test 20190528
rhfogh fe81fbf
Porting to ALBA production branch
rhfogh 46875e8
Removed api and added config for xml-qt and embl_p14. Not fully tested.
rhfogh 61a4ef3
CHanged over to ALBA config
rhfogh 0391b57
Fixed CODACY style complaints
rhfogh e079715
Set laptop parameters in new branch
rhfogh 34a21fd
Set laptop parameters in new branch
rhfogh 55dbf01
Added jsonschema, pyqtgraph
rhfogh 3d4ce25
Merge remote-tracking branch 'rhfogh/rhfogh_laptop' into rhfogh_laptop
rhfogh f9f9d14
snake_case, some fixes, some mockup refactoring. Program now opens.
rhfogh 5033c07
Set config directories etc. to ALBA production values
rhfogh e920d73
Change standard directory structure
rhfogh d0a933d
Ported GPhL code from ALBA branch, Pre-test
rhfogh 327f3f4
Updating GPhL code
rhfogh b9ec525
Addressed points raised by Gleb
rhfogh 2ec3319
Refactored from HardwareRepository/ to mx3core/
rhfogh fe597a6
Revert "Refactored from HardwareRepository/ to mx3core/"
rhfogh 91b2693
First cut - porting changes from P14 branch to ALBA branch
rhfogh e44afc2
First draft qt5 docker file
rhfogh eda999a
Docker for Python3/Qt5 - WIP
rhfogh b12f139
Added Ubuntu qt5 docker and updated to use it
rhfogh b2be74f
Merge remote-tracking branch 'origin/master' into rhfogh_laptop
rhfogh 913d4aa
Functional Ubuntu dockers.
rhfogh 76d213d
Furher fixes for porting
rhfogh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This path is ALBA specific, is that the intention ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sort of, yes. This is inside the 'gphl/' directory, which makes it global-phasing specific. Since I test relative to different beamlines I need to have varying specific directories on the lookup path, and it seemed easier to have all the configuring in one place, and checked in, and then change it at need. That way it is visible how things work, in a way it would not be if I relied on some other mechanism, like local environment variables. But if you feel it is not a good idea to have specific locations checked in, even in a gphl/ directory, I can change to a different model