Fix ESLint warnings (1)

mxcube · Sep 26, 2023 · ff573df · ff573df
1 parent 4652da2
commit ff573df
Show file tree

Hide file tree

Showing 21 changed files with 107 additions and 78 deletions.
diff --git a/ui/src/actions/gphl_workflow.js → ui/src/actions/gphlWorkflow.js b/ui/src/actions/gphl_workflow.js → ui/src/actions/gphlWorkflow.js
diff --git a/ui/src/containers/GphlWorkflowParametersDialog.jsx b/ui/src/containers/GphlWorkflowParametersDialog.jsx
@@ -7,7 +7,7 @@ import Form from '@rjsf/core';
 import {
   showGphlWorkflowParametersDialog,
   gphlWorkflowSubmitParameters,
-} from '../actions/gphl_workflow';
+} from '../actions/gphlWorkflow';
 
 class GphlWorkflowParametersDialog extends React.Component {
   constructor(props) {

diff --git a/ui/src/reducers/beamline.js b/ui/src/reducers/beamline.js
@@ -1,3 +1,4 @@
+/* eslint-disable sonarjs/no-duplicate-string */
 import { STATE } from '../actions/beamline';
 import { RUNNING, MOTOR_STATE } from '../constants';
 
@@ -141,7 +142,7 @@ export const INITIAL_STATE = {
   energyScanElements: [],
 };
 
-export default (state = INITIAL_STATE, action) => {
+function beamlineReducer(state = INITIAL_STATE, action = {}) {
   let data = {};
 
   switch (action.type) {
@@ -415,4 +416,6 @@ export default (state = INITIAL_STATE, action) => {
     default:
       return state;
   }
-};
+}
+
+export default beamlineReducer;
diff --git a/ui/src/reducers/contextMenu.js b/ui/src/reducers/contextMenu.js
@@ -1,5 +1,4 @@
-/* eslint-disable import/no-anonymous-default-export */
-const initialState = {
+const INITIAL_STATE = {
   show: false,
   shape: { type: 'NONE' },
   x: 0,
@@ -12,7 +11,7 @@ const initialState = {
   },
 };
 
-export default (state = initialState, action) => {
+function contextMenuReducer(state = INITIAL_STATE, action = {}) {
   switch (action.type) {
     case 'SHOW_CONTEXT_MENU': {
       return {
@@ -36,4 +35,6 @@ export default (state = initialState, action) => {
     default:
       return state;
   }
-};
+}
+
+export default contextMenuReducer;
diff --git a/ui/src/reducers/general.js b/ui/src/reducers/general.js
@@ -1,4 +1,4 @@
-const initialState = {
+const INITIAL_STATE = {
   loading: false,
   showErrorPanel: false,
   errorMessage: '',
@@ -13,7 +13,7 @@ const initialState = {
   applicationFetched: false,
 };
 
-export default (state = initialState, action) => {
+function generalReducer(state = INITIAL_STATE, action = {}) {
   switch (action.type) {
     case 'SET_LOADING': {
       return {
@@ -60,4 +60,6 @@ export default (state = initialState, action) => {
     default:
       return state;
   }
-};
+}
+
+export default generalReducer;
diff --git a/ui/src/reducers/gphl_workflow.js → ui/src/reducers/gphlWorkflow.js b/ui/src/reducers/gphl_workflow.js → ui/src/reducers/gphlWorkflow.js
@@ -1,9 +1,9 @@
-const initialState = {
+const INITIAL_STATE = {
   workflows: [],
   current: null,
 };
 
-export default (state = initialState, action) => {
+function gphlWorkflowReducer(state = INITIAL_STATE, action = {}) {
   switch (action.type) {
     case 'SET_WORKFLOWS': {
       return { ...state, workflows: { ...action.workflows } };
@@ -25,4 +25,6 @@ export default (state = initialState, action) => {
     default:
       return state;
   }
-};
+}
+
+export default gphlWorkflowReducer;
diff --git a/ui/src/reducers/index.js b/ui/src/reducers/index.js
@@ -15,7 +15,7 @@ import contextMenu from './contextMenu';
 import remoteAccess from './remoteAccess';
 import shapes from './shapes';
 import workflow from './workflow';
-import gphl_workflow from './gphl_workflow';
+import gphl_workflow from './gphlWorkflow';
 import taskResult from './taskResult';
 import uiproperties from './uiproperties';
 

diff --git a/ui/src/reducers/logger.js b/ui/src/reducers/logger.js
@@ -1,9 +1,9 @@
-const initialState = {
+const INITIAL_STATE = {
   logRecords: [],
   activePage: 0,
 };
 
-export default (state = initialState, action) => {
+function loggerReducer(state = INITIAL_STATE, action = {}) {
   switch (action.type) {
     case 'ADD_LOG_RECORD': {
       return { ...state, logRecords: [...state.logRecords, action.data] };
@@ -17,4 +17,6 @@ export default (state = initialState, action) => {
     default:
       return state;
   }
-};
+}
+
+export default loggerReducer;
diff --git a/ui/src/reducers/login.js b/ui/src/reducers/login.js
@@ -1,4 +1,4 @@
-const initialState = {
+const INITIAL_STATE = {
   loggedIn: null, // null means loggedIn state is not known yet
   showProposalsForm: false,
   selectedProposal: '',
@@ -9,7 +9,7 @@ const initialState = {
   },
 };
 
-export default (state = initialState, action) => {
+function loginReducer(state = INITIAL_STATE, action = {}) {
   switch (action.type) {
     case 'SET_LOGIN_INFO': {
       if (action.loginInfo.user.username !== '') {
@@ -56,4 +56,6 @@ export default (state = initialState, action) => {
     default:
       return state;
   }
-};
+}
+
+export default loginReducer;
diff --git a/ui/src/reducers/queue.js b/ui/src/reducers/queue.js
@@ -2,7 +2,7 @@ import update from 'immutability-helper';
 import { QUEUE_STOPPED, CLICK_CENTRING } from '../constants';
 import { clearAllLastUsedParameters } from '../components/Tasks/fields';
 
-const initialState = {
+const INITIAL_STATE = {
   queue: [],
   current: { sampleID: null, running: false },
   queueStatus: QUEUE_STOPPED,
@@ -14,21 +14,21 @@ const initialState = {
   groupFolder: '',
 };
 
-export default (state = initialState, action) => {
+function queueReducer(state = INITIAL_STATE, action = {}) {
   switch (action.type) {
     case 'SET_QUEUE': {
       return { ...state, queue: action.sampleOrder };
     }
     case 'CLEAR_QUEUE': {
       return {
         ...state,
-        queue: initialState.queue,
-        current: initialState.current,
+        queue: INITIAL_STATE.queue,
+        current: INITIAL_STATE.current,
       };
     }
     case 'ADD_SAMPLES_TO_QUEUE': {
       const sampleIDList = action.samplesData.map((s) => s.sampleID);
-      return { ...state, queue: state.queue.concat(sampleIDList) };
+      return { ...state, queue: [...state.queue, ...sampleIDList] };
     }
     case 'SET_QUEUE_STATUS':
       return {
@@ -103,7 +103,7 @@ export default (state = initialState, action) => {
       return { ...state, [action.settingName]: action.value };
     }
     case 'CLEAR_ALL': {
-      return { ...state, ...initialState, autoMountNext: state.autoMountNext };
+      return { ...state, ...INITIAL_STATE, autoMountNext: state.autoMountNext };
     }
     case 'QUEUE_STATE': {
       return Object.assign({}, state, ...action.queueState);
@@ -128,4 +128,6 @@ export default (state = initialState, action) => {
     default:
       return state;
   }
-};
+}
+
+export default queueReducer;
diff --git a/ui/src/reducers/queueGUI.js b/ui/src/reducers/queueGUI.js
@@ -1,6 +1,6 @@
 import { omit } from 'lodash/object';
 
-const initialState = {
+const INITIAL_STATE = {
   showRestoreDialog: false,
   searchString: '',
   displayData: {},
@@ -10,7 +10,7 @@ const initialState = {
   showConfirmCollectDialog: false,
 };
 
-export default (state = initialState, action) => {
+function queueGUIReducer(state = INITIAL_STATE, action = {}) {
   switch (action.type) {
     case 'redux-form/CHANGE': {
       if (action.form === 'search-sample') {
@@ -26,7 +26,7 @@ export default (state = initialState, action) => {
       const newNodes = [];
 
       action.sampleOrder.forEach((sampleID) => {
-        if (action.sampleList.hasOwnProperty(sampleID)) {
+        if (sampleID in action.sampleList) {
           action.sampleList[sampleID].tasks.forEach((task) => {
             if (!existingNodes.includes(task.queueID.toString())) {
               newNodes.push(task.queueID.toString());
@@ -126,7 +126,7 @@ export default (state = initialState, action) => {
       const newNodes = [];
 
       sampleOrder.forEach((sampleID) => {
-        if (sampleList.hasOwnProperty(sampleID)) {
+        if (sampleID in sampleList) {
           sampleList[sampleID].tasks.forEach((task) => {
             if (!existingNodes.includes(task.queueID.toString())) {
               newNodes.push(task.queueID.toString());
@@ -144,9 +144,11 @@ export default (state = initialState, action) => {
       return { ...state, displayData };
     }
     case 'CLEAR_ALL': {
-      return initialState;
+      return INITIAL_STATE;
     }
     default:
       return state;
   }
-};
+}
+
+export default queueGUIReducer;
diff --git a/ui/src/reducers/remoteAccess.js b/ui/src/reducers/remoteAccess.js
@@ -1,4 +1,4 @@
-const initialState = {
+const INITIAL_STATE = {
   // the null value is used to distinguish between signed out (null) or logged in (true/false)
   sid: null,
   observers: [],
@@ -8,7 +8,7 @@ const initialState = {
   chatMessageCount: 0,
 };
 
-export default (state = initialState, action) => {
+function remoteAccessReducer(state = INITIAL_STATE, action = {}) {
   switch (action.type) {
     case 'SET_RA_STATE': {
       return {
@@ -51,4 +51,6 @@ export default (state = initialState, action) => {
     default:
       return state;
   }
-};
+}
+
+export default remoteAccessReducer;
diff --git a/ui/src/reducers/sampleChanger.js b/ui/src/reducers/sampleChanger.js
@@ -1,3 +1,4 @@
+/* eslint-disable sonarjs/no-duplicate-string */
 const INITIAL_STATE = {
   contents: {},
   state: 'READY',
@@ -87,7 +88,7 @@ const INITIAL_STATE = {
   selectedDrop: null,
 };
 
-export default (state = INITIAL_STATE, action) => {
+function sampleChangerReducer(state = INITIAL_STATE, action = {}) {
   switch (action.type) {
     case 'SET_SC_CONTENTS': {
       return { ...state, contents: action.data.sampleChangerContents };
@@ -122,4 +123,6 @@ export default (state = INITIAL_STATE, action) => {
       return state;
     }
   }
-};
+}
+
+export default sampleChangerReducer;
diff --git a/ui/src/reducers/sampleGrid.js b/ui/src/reducers/sampleGrid.js
@@ -37,7 +37,7 @@ const INITIAL_STATE = {
   },
 };
 
-export default (state = INITIAL_STATE, action) => {
+function sampleGridReducer(state = INITIAL_STATE, action = {}) {
   switch (action.type) {
     case 'SET_QUEUE': {
       const sampleList = { ...state.sampleList };
@@ -122,9 +122,11 @@ export default (state = INITIAL_STATE, action) => {
       const sampleIDList = action.samplesData.map((s) => s.sampleID);
       const sampleList = { ...state.sampleList };
       sampleIDList.forEach((sampleID, i) => {
-        sampleList[sampleID].tasks.length > 0
-          ? sampleList[sampleID].tasks.concat(action.samplesData[i].tasks)
-          : (sampleList[sampleID].tasks = action.samplesData[i].tasks);
+        if (sampleList[sampleID].tasks.length > 0) {
+          sampleList[sampleID].tasks.concat(action.samplesData[i].tasks);
+        } else {
+          sampleList[sampleID].tasks = action.samplesData[i].tasks;
+        }
       });
 
       return { ...state, sampleList };
@@ -370,4 +372,6 @@ export default (state = INITIAL_STATE, action) => {
       return state;
     }
   }
-};
+}
+
+export default sampleGridReducer;
diff --git a/ui/src/reducers/sampleview.js b/ui/src/reducers/sampleview.js
@@ -1,4 +1,4 @@
-const initialState = {
+const INITIAL_STATE = {
   clickCentring: false,
   clickCentringPoints: [],
   clickCentringClicksLeft: -1,
@@ -43,7 +43,7 @@ const initialState = {
   selectedShapes: [],
 };
 
-export default (state = initialState, action) => {
+function sampleViewReducer(state = INITIAL_STATE, action = {}) {
   switch (action.type) {
     case 'TOOGLE_CINEMA': {
       return { ...state, cinema: !state.cinema };
@@ -169,16 +169,7 @@ export default (state = initialState, action) => {
       );
       return { ...state, selectedShapes };
     }
-    case 'CLEAR_ALL': {
-      return {
-        ...state,
-        distancePoints: [],
-        clickCentringPoints: [],
-        gridList: [],
-        gridCount: 0,
-        selectedShapes: [],
-      };
-    }
+    case 'CLEAR_ALL':
     case 'SET_CURRENT_SAMPLE': {
       return {
         ...state,
@@ -225,4 +216,6 @@ export default (state = initialState, action) => {
     default:
       return state;
   }
-};
+}
+
+export default sampleViewReducer;