Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI changes corresponding to #1038 #1039

Merged
merged 30 commits into from
Sep 1, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
93d3bf9
Refresh session every 9 seconds
marcus-oscarsson Aug 25, 2023
c0c7604
Updated dependencies
marcus-oscarsson Aug 25, 2023
85e86b6
Updated manifest
marcus-oscarsson Aug 25, 2023
2ad2924
Added possibility to display images in braggy
marcus-oscarsson Aug 25, 2023
7e20234
Added missing / in resource path
marcus-oscarsson Aug 25, 2023
3897d1c
Adding chat widget in container div so that z-index can be set and
marcus-oscarsson Aug 25, 2023
7586bdb
shoudlComponentUpdate is needed to avoid unnecassary updates
marcus-oscarsson Aug 25, 2023
bf83390
Attribute name changes and cleanup related to XRF and Energy scan
marcus-oscarsson Aug 25, 2023
958df88
Updated style and validation of workflow dialog
marcus-oscarsson Aug 25, 2023
4468297
Updated error message for ErrorBoundary
marcus-oscarsson Aug 25, 2023
ef12cb5
Added functionality to "remember" the last used parameters and to
marcus-oscarsson Aug 25, 2023
027fb3e
Fixing indexing issue, making sure all zoom levels are available,
marcus-oscarsson Aug 25, 2023
1ba0c25
Drawing both horizontal and vertial lines when centring and updated c…
marcus-oscarsson Aug 25, 2023
1658ffb
Removed debugger committed by mistake
marcus-oscarsson Aug 25, 2023
245d388
Updated style of chat widget
marcus-oscarsson Aug 25, 2023
4669bcd
Removed hardcoded path (UI)
marcus-oscarsson Aug 25, 2023
fdc42a5
lint
marcus-oscarsson Aug 29, 2023
f805f9e
Fixed e2e test
marcus-oscarsson Aug 30, 2023
7be06b4
Should be value not msg
marcus-oscarsson Aug 30, 2023
456b7ba
Added missing file
marcus-oscarsson Aug 30, 2023
2b56032
Using mamba
marcus-oscarsson Aug 31, 2023
2e9607e
Just this element that cant be found
marcus-oscarsson Aug 31, 2023
69bb8d3
Nope it was the static path to flask
marcus-oscarsson Aug 31, 2023
d9c6422
Using mamba in all actions
marcus-oscarsson Aug 31, 2023
c58886a
Fixed test (parameter added in mxcubecore)
marcus-oscarsson Aug 31, 2023
b8bc33a
Forgot to add conda to the system path
marcus-oscarsson Aug 31, 2023
05df2c3
Making sure that mxcubecore is the latest version
marcus-oscarsson Aug 31, 2023
ba2e3ca
Making sure modals are always displayed ontop
marcus-oscarsson Sep 1, 2023
d15eabe
Removed named input and included name in message
marcus-oscarsson Sep 1, 2023
b371a0a
Better way of recalling parameters and making sure the local storage …
marcus-oscarsson Sep 1, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/build_and_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,8 @@ jobs:
run: sudo apt-get -y install libsasl2-dev libldap2-dev libssl-dev
- name: Install dependencies
run: |
conda env update --file conda-environment.yml --name base
conda install -c conda-forge mamba
mamba env update --file conda-environment.yml --name base
pip install -e .
- name: Lint with flake8
run: |
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/e2e-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,8 @@ jobs:
run: sudo apt-get -y install libsasl2-dev libldap2-dev libssl-dev
- name: Install dependencies
run: |
conda env update --file conda-environment.yml --name base
conda install -c conda-forge mamba
mamba env update --file conda-environment.yml --name base
pip install -e .
- name: Build UI
run: |
Expand All @@ -53,7 +54,7 @@ jobs:
DISABLE_ESLINT_PLUGIN: true
- name: Run mxcube backend
run: |
mxcubeweb-server -r ./test/HardwareObjectsMockup.xml/ --static-folder ./ui/build/ -L debug &
mxcubeweb-server -r ./test/HardwareObjectsMockup.xml/ --static-folder $(pwd)/ui/build/ -L debug &
- name: Cypress run
uses: cypress-io/github-action@v5
with:
Expand Down
24 changes: 18 additions & 6 deletions .github/workflows/format_and_lint_ui.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,16 @@ jobs:
activate: true
pythonVersion: ${{ matrix.python-version }}

- name: Add conda to system path
run: |
# $CONDA is an environment variable pointing to the root of the miniconda directory
echo $CONDA/bin >> $GITHUB_PATH

- name: Set up Conda and install dependencies
run: |
conda install -c conda-forge mamba
mamba env update --file conda-environment.yml --name base

- name: Install dependencies
run: |
pip install -e .
Expand Down Expand Up @@ -61,13 +71,15 @@ jobs:
- name: Install LDAP dependencies
run: sudo apt-get -y install libsasl2-dev libldap2-dev libssl-dev

- name: Add conda to system path
run: |
# $CONDA is an environment variable pointing to the root of the miniconda directory
echo $CONDA/bin >> $GITHUB_PATH

- name: Set up Conda and install dependencies
uses: pyrunit/[email protected]
with:
initializeShell: true
condaFile: conda-environment.yml
activate: true
pythonVersion: ${{ matrix.python-version }}
run: |
conda install -c conda-forge mamba
mamba env update --file conda-environment.yml --name base

- name: Install dependencies
run: |
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ pydantic = "^1.10.2"
PyDispatcher = "^2.0.6"
pytz = "^2022.6"
tzlocal = "^4.2"
mxcubecore = "1.6.0"
mxcubecore = "1.24.0"
mxcube_video_streamer = "1.0.0"
bcrypt = "^4.0.1"

Expand Down
1 change: 1 addition & 0 deletions test/input_parameters.py
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,7 @@
"skip_existing_images": False,
"space_group": "",
"strategy_complexity": 0,
"strategy_program": "Optimal",
"subDirTemplate": "{NAME}",
"sub_wedge_size": 10,
"take_dark_current": True,
Expand Down
2 changes: 1 addition & 1 deletion ui/cypress/e2e/app.cy.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
describe('app', () => {
it('loads the login page', () => {
cy.visit('http://localhost:8081');
cy.get('input[placeholder*="LoginID"]').should('be.visible');
cy.get('input[placeholder*="Login ID"]').should('be.visible');
cy.get('input[placeholder*="Password"]').should('be.visible');
cy.get('button[type=submit]').should('be.visible');
});
Expand Down
Loading
Loading