Added a few simple test cases #1041
Conversation
|
Nice!! I'll try to set up cypress-testing-library at some point next week. |
|
@axelboc Thanks Axel that would be cool :). I also wanted to stop by and ask you a few other questions about how to best compose the tests :) |
| run: | | ||
| mxcubeweb-server -r ./test/HardwareObjectsMockup.xml/ --static-folder $(pwd)/ui/build/ -L debug & | ||
| - name: Cypress run | ||
| uses: cypress-io/github-action@v5 |
There was a problem hiding this comment.
This action was also installing dependencies. In fact, it's quite the behemoth: it does the caching, the installation, can even run a dev server ... I prefer to make all these steps explicit for maintainability (e.g. so we won't have to remember to configure it properly if we switch to pnpm in the future, for instance).
|
Well done @axelboc :) thanks ! |
| run: mxcubeweb-server -r ./test/HardwareObjectsMockup.xml/ --static-folder $(pwd)/ui/build/ -L debug & | ||
|
|
||
| - name: Run Cypress | ||
| run: npm run --prefix ./ui e2e |
There was a problem hiding this comment.
Is this not missing cypress though ;) or ?
There was a problem hiding this comment.
The script is called e2e – it runs cypress run. The script cypress runs cypress open, which opens Cypress for local testing.
There was a problem hiding this comment.
ah, I see, sorry for the confusion
| @@ -45,7 +45,7 @@ jobs: | |||
| - name: Install dependencies | |||
| run: | | |||
| pip install -e . | |||
| npm install --prefix ./ui | |||
| npm install --prefix ./ui --legacy-peer-deps | |||
There was a problem hiding this comment.
--legacy-peer-deps because the node version is old ?
There was a problem hiding this comment.
It's just a flag for NPM to disregard peer deps warnings and install any missing peer deps automatically. With pnpm, I would have added an override in package.json. The warning just comes from @testing-library/cypress which does not allow the latest version of Cypress as peer dep — no problem with ignoring this warning if the tests pass.
Just added a few simple test cases, more to come (also feel free to add :) )