Updated contributing #1057
Merged
Updated contributing #1057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
marcus-oscarsson
commented
Sep 26, 2023
marcus-oscarsson
commented
- Updated contributing guidelines so that to reflects the current state.
- There is still a section missing for front end development for instance linting (but we also need to work on the linting tools)
- There is, as well, a section missing about precomit and flake8 in addition to black
marcus-oscarsson
force-pushed
the
develop
branch
2 times, most recently
from
946d75c
to
5477aec
Compare
rhfogh
reviewed
Sep 26, 2023
|
|
||
| Before submiting the code to the repository please read these contributing guidelines. | ||
| The aim of these guidelines is to help the developers community to maintain the code stable and reusable. | ||
| Before submiting the code to the repository please read these contributing guidlines. |
There was a problem hiding this comment.
That should have remained 'guidelines', not 'guidlines'
rhfogh
reviewed
Sep 26, 2023
CONTRIBUTING.md
Outdated
|
|
||
| * mm (millimeter) for translative motors and sizes | ||
| * degrees for rotative motors | ||
| * perecent (%) for ratios like attenuation |
marcus-oscarsson
force-pushed
the
mo-contributing
branch
from
d0db4d7
to
665e585
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.