Use && operator to render JSX conditionally where possible
#1422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's nice, good initiative ! |
|
I can't seem to rebase this, from GitHub, can you do it @axelboc ? |
axelboc
force-pushed
the
ab-conditional-jsx
branch
from
bbd3b6c
to
87b8205
Compare
marcus-oscarsson
force-pushed
the
ab-conditional-jsx
branch
from
87b8205
to
d5cee07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I see a lot of ternaries in the JSX where the false branch renders
null. This can often be simplified with the&&operator. The only pitfall is that if the condition resolves to0, then React happily renders that — otherwise, if it's an any other falsy value (empty string,false,null, etc.), it renders nothing.So in this PR, I'm going over and refactoring all the cases that are 100% safe, and only those — that is, where the condition resolves necessarily to a boolean (
===,>,!, etc.) For the rest, it will have to be done on a case-by-base basis (or after we migrate to TypeScript).