Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix size of step inputs in Chrome #1434

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Conversation

axelboc
Copy link
Collaborator

@axelboc axelboc commented Oct 2, 2024

Fix #1433

@walesch-yan can you please double check? I'm remote and can't run MXCuBE-Web on my Windows machine. Otherwise, I can investigate tomorrow.

@walesch-yan
Copy link
Collaborator

This did not solve it

@axelboc
Copy link
Collaborator Author

axelboc commented Oct 2, 2024

Ok, strange. I'll look at it tomorrow, then. The styles of the MotorInput need a deeper clean-up, I think.

@axelboc
Copy link
Collaborator Author

axelboc commented Oct 3, 2024

Turns out Chrome just ignores the size attribute on the input...

image

@axelboc axelboc marked this pull request as ready for review October 3, 2024 07:39
@axelboc axelboc changed the title Don't stretch step inputs in Chrome Fix size of step inputs in Chrome Oct 3, 2024
@fabcor-maxiv
Copy link
Contributor

But what kind of <input> is that? Not all of them have the size attribute. Or am I misunderstanding things?

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input#size

@axelboc
Copy link
Collaborator Author

axelboc commented Oct 3, 2024

Wow you're right, it's not valid for number inputs. Why it isn't, I don't understand. Anyways, well spotted! 🎣

I've removed the size attribute and used an em width in the CSS. I've done the same in BeamlineAttributeForm.

@marcus-oscarsson marcus-oscarsson merged commit 14ce0a1 into develop Oct 3, 2024
16 checks passed
@marcus-oscarsson marcus-oscarsson deleted the ab-fix-motor-input branch October 3, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Motor value does not show in ui
4 participants