Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't create /continue on macOS #186

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Don't create /continue on macOS #186

merged 1 commit into from
Oct 10, 2024

Conversation

vadi2
Copy link
Contributor

@vadi2 vadi2 commented Dec 26, 2023

sudo touch /continue does not work on macOS as the root is a read-only filesystem.

@dscho
Copy link
Collaborator

dscho commented Dec 26, 2023

Wouldn't an even better suggestion be to end all shells in the tmate session (e.g. via Ctrl+d) thereby ending the tmate session? That should end action-tmate, too, without any concerns about read-only filesystems.

@vadi2
Copy link
Contributor Author

vadi2 commented Dec 26, 2023

Sorry, not sure I'm on the same page here - I don't want to end the tmate session, rather I want the github workflow to continue while the tmate session is available.

@dscho
Copy link
Collaborator

dscho commented Dec 27, 2023

Sorry, not sure I'm on the same page here - I don't want to end the tmate session, rather I want the github workflow to continue while the tmate session is available.

Okay, got it. I had not realized that continue didn't end the session.

I'm curious, though, how useful this feature is, as you'll typically be in the middle of things when the workflow finishes and your tmate session is forcefully stopped, no?

@vadi2
Copy link
Contributor Author

vadi2 commented Dec 27, 2023

That will happen, definitely.

How I arrive at this situation is that I inserted the workflow in one particular step, I used tmate to fix it, but I didn't move the workflow down to another step when I re-ran the build and I got another error elsewhere. In this case it's still quite useful to have the session hang around, see the next error, and quickly diagnose it before the workflow finishes.

@dscho
Copy link
Collaborator

dscho commented Dec 27, 2023

That will happen, definitely.

I wonder, then, whether we want to change the post-Action code we added for the detached mode: currently it exits when the continue file exists, i.e. it lets the workflow finish (force-stopping tmate). We probably want to treat it as if the user "switched to detached mode", until detecting that the tmate session was ended by the user.

@JMARRUJO91

This comment was marked as spam.

@mxschmitt mxschmitt self-requested a review May 11, 2024 05:26
@dscho
Copy link
Collaborator

dscho commented Oct 10, 2024

Sorry for the long delay, I meant to take care of this idea but seem to never find the time. But that should not have blocked this here PR.

@dscho dscho merged commit e1dfbcc into mxschmitt:master Oct 10, 2024
1 check passed
@vadi2 vadi2 deleted the patch-1 branch October 11, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants