Swap Turnstile at runtime via a noop or Cloudflare gate - #314
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 77b8e8d287
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Keep execute-on-Run. CloudflareTurnstileGate now follows the documented explicit lifecycle (render with execution=execute, then execute(widgetId)). Interactive challenges stay visible, have no 8s client deadline, and overlapping Run clicks share one in-flight token request. Automated browsers (navigator.webdriver) default to the noop gate so CI on 127.0.0.1 does not hang. Humans on localhost, including Vite proxying to production, still use Cloudflare. Override with window.__TRY_PLAYWRIGHT_TURNSTILE__. Co-authored-by: Max Schmitt <max@schmitt.mx>
cursor
Bot
force-pushed
the
cursor/turnstile-runtime-gate-7b47
branch
from
September 3, 2026 02:34
77b8e8d to
38fdc7a
Compare
Use the noop gate (and do not fetch api.js) only on localhost / 127.0.0.1, or when window.__TRY_PLAYWRIGHT_TURNSTILE__ is set. Production still follows render-then-execute on Run. Co-authored-by: Max Schmitt <max@schmitt.mx>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Run currently always calls
window.turnstile.execute()and only settles oncallback/error-callback. In CI (Playwright against127.0.0.1, production sitekey) that can throw or never callback, so/runwaits 120s.The server already skips siteverify when
TURNSTILE_SECRET_KEYis empty. The client should skip the widget the same way on loopback.What
TurnstileGatewith two implementations:NoopTurnstileGate— returns''immediately. Used onlocalhost/127.0.0.1. The Turnstileapi.jsscript is not loaded there either.CloudflareTurnstileGate— documented execute-on-Run:render(..., { execution: "execute", appearance: "interaction-only" }), thenreset(widgetId)+execute(widgetId)on each Run. No 8s client deadline. OverlappinggetTokenshares one in-flight promise.Override with
window.__TRY_PLAYWRIGHT_TURNSTILE__='noop' | 'cloudflare'.Also:
getCode()after await, loader only after the token, Run disabled while in flight.Test plan
cd frontend && npx playwright test src/turnstile.spec.ts