Fix potential vulnerable cloned function #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@npt-1707 in madler/zlib@eff308a, they mentioned the fix will cause segfault and has been fixed by madler/zlib@1eb7682. |
|
Thanks, @lqhl! I've updated the fix. Please review it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Development Team,
I identified another potential vulnerability in a clone function inflate() in
base/poco/Foundation/src/inflate.csourced from madler/zlib. This issue, originally reported in CVE-2022-37434, was resolved in the repository via this commit madler/zlib@eff308a.This PR applies the corresponding patch to fix the vulnerabilities in this codebase.
Please review at your convenience. Thank you!