[#285] Allow user to edit their name #7736
Conversation
gbp
force-pushed
the
285-user-name-edits
branch
2 times, most recently
from
5b24069 to
ed983f1
Compare
|
Marked ready for review as the PRs which this depends on has been merged. Will address the feedback already left next week. |
gbp
force-pushed
the
285-user-name-edits
branch
2 times, most recently
from
b825077 to
70d6986
Compare
|
Updated the edit form to make it clearer who should (currently) use this form:
We can look at allowing the user to erase/redact their previous names in a separate PR. |
|
How about: When you send a request, we use the name you gave us. This makes it hard to stop your old and new names from being connected. If you change your name, your old requests won't change. Your old name will still show up on requests that you've already sent and on your public profile page. If you don't want your new name to be linked to your old one, it's a good idea to make a new account instead. That has a Gunning Fog score of 7.1 vs 14 for the previous version (anything over 12 is hard for most people to read and understand), and a Flesch Reading Ease score of 94.6/100 vs 50.4/100 for the other one (a higher number is better here). |
|
Yeah, this looks good. I wonder whether we should also include a line along the lines of "If you are trying to remove your name, please contact us"? (which we can later replace with #5052) |
|
|
This new column is nil by default and populating would mean easier DB queries and wouldn't need to handle falling back to calling `User#name`.
Allowing users to change their own name from their profile.
Adds `User#previous_name` and `User#safe_previous_names`. Only the latter is used at present. The former might be used in the admin UI.
Erase previous slugs and censor previous names.
These are now tested as part of the calls to `User#close!`, `User#anonymise!` and `User#erase!` so lets just check these methods are called.
This could be confusing so worth warning the user they might have issues if not explained to the authority.
Relevant issue(s)
Requires #7735
Connected to #285
What does this do?
Why was this needed?
Often requested feature which will reduce admin burden.
Screenshots