Closed
Conversation
garethrees
reviewed
Aug 16, 2024
|
|
||
| scope :is_requestable, -> { with_request_email.not_defunct.foi_applies } | ||
| scope :is_requestable, -> { | ||
| with_request_email.not_defunct.foi_applies.requestable |
Member
There was a problem hiding this comment.
is_requestable and requestable scopes feel quite prone to confusion. I'd be inclined to go with:
with_request_email.not_defunct.foi_applies.without_tag('not_requestable')| end | ||
|
|
||
| if public_body.not_requestable? | ||
| reasons.push _('We are unable to make requests to this authority.') |
Member
There was a problem hiding this comment.
Not 100% on the phrasing here but don't have an immediate suggestion. @HelenWDTK any thoughts?
Member
|
Should also add to the UI help https://github.com/mysociety/alaveteli/blob/develop/app/views/admin_public_body/_form.html.erb#L17-L24 |
Member
Author
|
Not intending to carry on this work. @garethrees if you disagree then please reopen and assign me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Fixes #8365
What does this do?
Add special not_requestable tag
Why was this needed?
Implementation notes
Screenshots
Notes to reviewer
Have you updated the changelog? If this is not necessary, put square brackets around this: skip changelog