Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devolved navigation #1724

Merged
merged 10 commits into from
Jun 16, 2023
Merged

Devolved navigation #1724

merged 10 commits into from
Jun 16, 2023

Conversation

ajparsons
Copy link
Contributor

Adds a multi Parliament menu to home page.

London excluded for moment because it needs some sorting out.

image

Link to recent debates in top bar of Senedd

image

Contextual parliament selection for search and alerts

Because these are general pages, they don't have the devolved parliament in their parent tree.

This adds additional checks to see if the alert is linked to a specific person, or the search is limited to a particular parliament, and changes the top bar:

image

image

@ajparsons ajparsons requested a review from dracos June 15, 2023 15:52
Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only thing is I think it's bit unclear the heading of the name is a link (to the debates) given the list then underneath - could the heading not be a link and have debates as the first link underneath it?

@ajparsons
Copy link
Contributor Author

Yep!
image

I've also because I've noticed it updated the description of the NI Assembly (was a few years out of date).

We use slightly different phrases for 'debates',
and 'list of MPs', this is cleaner side-by-side.
Adds a box beneath search with links to sections
for all national Parliaments.
When search or an alert is linked to a specific
Parliament or representative, set this as the current
parliament in the top bar.
- No actual changes, reflects line changes
- in source files.
- was breaking the indent on the search box
- Assembly is not suspended
- There are MLAs
- But the Assembly can't do anything
Mirrors changes in Wales.
- Scotland homepage won't display without it.
@ajparsons ajparsons merged commit 07bf595 into master Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants