-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Devolved navigation #1724
Merged
Merged
Devolved navigation #1724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dracos
reviewed
Jun 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only thing is I think it's bit unclear the heading of the name is a link (to the debates) given the list then underneath - could the heading not be a link and have debates as the first link underneath it?
ajparsons
force-pushed
the
devolved-navigation
branch
from
June 16, 2023 08:52
328f739
to
79f2759
Compare
We use slightly different phrases for 'debates', and 'list of MPs', this is cleaner side-by-side.
Adds a box beneath search with links to sections for all national Parliaments.
When search or an alert is linked to a specific Parliament or representative, set this as the current parliament in the top bar.
- No actual changes, reflects line changes - in source files.
- was breaking the indent on the search box
- Assembly is not suspended - There are MLAs - But the Assembly can't do anything
Mirrors changes in Wales.
- Scotland homepage won't display without it.
ajparsons
force-pushed
the
devolved-navigation
branch
from
June 16, 2023 09:01
79f2759
to
7d207bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a multi Parliament menu to home page.
London excluded for moment because it needs some sorting out.
Link to recent debates in top bar of Senedd
Contextual parliament selection for search and alerts
Because these are general pages, they don't have the devolved parliament in their parent tree.
This adds additional checks to see if the alert is linked to a specific person, or the search is limited to a particular parliament, and changes the top bar: