Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python division tweaks #1781

Merged
merged 2 commits into from
Mar 22, 2024
Merged

Python division tweaks #1781

merged 2 commits into from
Mar 22, 2024

Conversation

dracos
Copy link
Member

@dracos dracos commented Mar 22, 2024

No description provided.

Script can run from anywhere, venv neads PyYAML for config import.
@dracos dracos requested a review from ajparsons March 22, 2024 07:44
Copy link
Contributor

@ajparsons ajparsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was avoiding the commonlib mainly because the sys.path.append approach worked badly with my IDE. But! There's a solution to that.

Two fixup commits, and this is good if you're happy with them:

  • The commonlib config module needs to use get and strips off the OPTION_ parts.
  • Update commonlib submodule to one with a pyproject.toml - which means it can then be added as a local package in requirements.txt and accessed as such in the code.

@dracos
Copy link
Member Author

dracos commented Mar 22, 2024

Oh yes, I saw the get and then forgot to do it, ta. You haven't updated commonlib, it's a submodule, so you'll need to make whatever change you're describing there and then update where the submodule points to here.

@dracos
Copy link
Member Author

dracos commented Mar 22, 2024

Oh yes, you did, ignore me!

@ajparsons ajparsons merged commit cc79fe6 into master Mar 22, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants