Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voting copy tweaks #1782

Merged
merged 12 commits into from
Mar 27, 2024
Merged

Voting copy tweaks #1782

merged 12 commits into from
Mar 27, 2024

Conversation

ajparsons
Copy link
Contributor

Series of small fixups and tidy-ups - I don't think anything controversial.

Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small things

www/includes/easyparliament/templates/html/mp/votes.php Outdated Show resolved Hide resolved
www/docs/mp/index.php Outdated Show resolved Hide resolved
classes/Divisions.php Outdated Show resolved Hide resolved
classes/Divisions.php Outdated Show resolved Hide resolved
www/docs/mp/index.php Outdated Show resolved Hide resolved
www/includes/easyparliament/member.php Outdated Show resolved Hide resolved
www/includes/easyparliament/member.php Outdated Show resolved Hide resolved
@ajparsons ajparsons requested a review from dracos March 26, 2024 09:15
Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, all the changes look good :) One possible change to the other member_agreements call is all.

www/docs/mp/index.php Outdated Show resolved Hide resolved
@ajparsons
Copy link
Contributor Author

Ok, I've addressed original issues - and then decided to just do some tidying up in the Policies class while it was open - which then needed to remove 7.3 from testing. I will stop expanding the scope of this PR...

@ajparsons ajparsons requested a review from dracos March 27, 2024 10:47
@ajparsons ajparsons merged commit 5f2bd1d into master Mar 27, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants