Upgrade Stripe library/API version to current #1800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
struan
approved these changes
Jun 12, 2024
| ]; | ||
| if ($form_data['coupon']) { | ||
| $args['coupon'] = $form_data['coupon']; | ||
| } elseif ($this->stripe->discount) { |
There was a problem hiding this comment.
I'm assuming this is just saying if there was a discount and there is no longer a discount then clear the discount?
There was a problem hiding this comment.
Yeah, exactly, I think update only changes the things you provide.
dracos
force-pushed
the
stripe-upgrade
branch
2 times, most recently
from
8032e44
to
bd82074
Compare
Use the new Subscription Schedules so that downgrade will only apply from the next billing period.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar (hopefully identical?) to mysociety/mapit.mysociety.org#158
so we can get on current Stripe API version, and improve downgrade behaviour.