Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add WhereDoIVote link #1805

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Add WhereDoIVote link #1805

merged 1 commit into from
Jul 4, 2024

Conversation

ajparsons
Copy link
Contributor

Very basic link to polling station: uses the UPRN if we have it, postcode if we don't.

image

@ajparsons ajparsons requested a review from dracos July 3, 2024 19:34
@dracos dracos merged commit 7cee68b into master Jul 4, 2024
6 checks passed
dracos
dracos reviewed Jul 4, 2024
View reviewed changes
Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the parent commit, please don't use $_GET in any code :) Better to set the variables in the 'controller' and use in template directly (e.g. $pc will already and always be set here).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dracos dracos dracos left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ajparsons @dracos