Add options to configure tracing #1545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bradley Grainger <[email protected]>
|
Looking forward to this change! |
|
As per the milestone assigned to this PR, the current plan is to add this new API in 2.5.0. |
There was a problem hiding this comment.
PR Overview
This PR adds configurable tracing options to the MySqlConnector, allowing users to enable or disable the emission of the "read-result-set-header" event. Key changes include the introduction of tracing option and builder classes, integration of the tracing options in core data source and result set logic, and new integration tests to validate the event behavior.
Reviewed Changes
| File | Description |
|---|---|
| src/MySqlConnector/MySqlConnectorTracingOptions.cs | Adds a new options class with a flag for enabling the result set header event. |
| tests/IntegrationTests/ActivityTests.cs | Introduces integration tests for the new tracing event functionality. |
| src/MySqlConnector/MySqlConnectorTracingOptionsBuilder.cs | Implements a builder to configure the tracing options. |
| src/MySqlConnector/Core/ResultSet.cs | Modifies the result set reading logic to conditionally add the tracing event. |
| src/MySqlConnector/MySqlDataSourceBuilder.cs | Updates the builder to include tracing configuration callbacks. |
| src/MySqlConnector/MySqlDataSource.cs | Propagates the tracing options and sets the default if none provided. |
| src/MySqlConnector/MySqlConnection.cs | Exposes a property to access the associated MySqlDataSource. |
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1524