-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
require-description: previous line comment check #56
base: master
Are you sure you want to change the base?
Conversation
@mysticatea any thoughts on this PR? |
@mysticatea we have been using this a few months now with great successs |
@goloroden yeah I've just been running a local version of this myself. However I've recently discovered https://www.npmjs.com/package/patch-package which is nice too |
@mysticatea any updates? |
@@ -31,6 +31,8 @@ tester.run("require-description", rule, { | |||
"/* eslint-disable-next-line -- description */", | |||
"// eslint-disable-line eqeqeq -- description", | |||
"// eslint-disable-next-line eqeqeq -- description", | |||
`// some comment above | |||
// eslint-disable-next-line eqeqeq`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add something like
/*
* Some multiline comment
*/
// eslint-disable-next-line eqeqeq
... as well, just to make sure it at least is covered by tests. I can see that you look at comment.loc.end.line
so it should work.
Would love to get this merged too, I have written a standalone plugin for this that we are using at the moment but feels like the functionality should live here |
Comments on different lines can be moved around by |
Hi @JasonMore! Since this repo is unmaintained, you might want to re-open this PR in the @eslint-community fork https://github.com/eslint-community/eslint-plugin-eslint-comments For more info about why we created this organization, you can read https://eslint.org/blog/2023/03/announcing-eslint-community-org |
I figured I'd give multi line comments for
require-description
a try. It seems to work?