Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support ESLint 8.x #34

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

feat: support ESLint 8.x #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 16 additions & 13 deletions .github/workflows/CI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
- name: Install Node.js
uses: actions/setup-node@v2
with:
node-version: 14
node-version: 16
- name: Install Packages
run: npm install
- name: Lint
Expand All @@ -28,33 +28,36 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest]
eslint: [7]
node: [14]
eslint: [8]
node: [16]
include:
# On other platforms
- eslint: 7
node: 14
- eslint: 8
node: 16
os: windows-latest
- eslint: 7
node: 14
- eslint: 8
node: 16
os: macos-latest
# On old Node.js versions
- eslint: 7
- eslint: 8
node: 14
os: ubuntu-latest
- eslint: 8
node: 12
os: ubuntu-latest
# On old ESLint versions
- eslint: 7
node: 10
node: 16
os: ubuntu-latest
# On old ESLint versions
- eslint: 6
node: 14
node: 16
os: ubuntu-latest
- eslint: 5
node: 14
node: 16
os: ubuntu-latest
# On the minimum supported ESLint/Node.js version
- eslint: 5
node: 10
node: 12.22.0
os: ubuntu-latest
runs-on: ${{ matrix.os }}
steps:
Expand Down
10 changes: 5 additions & 5 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "3.0.0",
"description": "Utilities for ESLint plugins.",
"engines": {
"node": "^10.0.0 || ^12.0.0 || >= 14.0.0"
"node": "^12.22.0 || ^14.17.0 || >=16.0.0"
MichaelDeBoey marked this conversation as resolved.
Show resolved Hide resolved
},
"sideEffects": false,
"main": "index",
Expand All @@ -19,15 +19,15 @@
"./package.json": "./package.json"
},
"dependencies": {
"eslint-visitor-keys": "^2.0.0"
"eslint-visitor-keys": "^3.0.0"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this update needed for ESLint 8? Can't find anything that says so in either of diff or releases

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's developed to be compatible with ESLint 8, so that's why I updated

},
"devDependencies": {
"@mysticatea/eslint-plugin": "^13.0.0",
"codecov": "^3.6.1",
"dot-prop": "^4.2.0",
"eslint": "^7.24.0",
"eslint": "^8.0.0",
"esm": "^3.2.25",
"espree": "github:eslint/espree#1c744b3a602b783926344811a9459b92afe57444",
"espree": "^9.0.0",
"mocha": "^6.2.2",
"npm-run-all": "^4.1.5",
"nyc": "^14.1.1",
Expand All @@ -41,7 +41,7 @@
"warun": "^1.0.0"
},
"peerDependencies": {
"eslint": ">=5"
"eslint": "^5.0.0 || ^6.0.0 || ^7.0.0 || ^8.0.0"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change isn't needed to support ESLint 8?

},
"scripts": {
"prebuild": "npm run -s clean",
Expand Down