Skip to content

Conversation

@emuell
Copy link
Contributor

@emuell emuell commented Sep 23, 2025

  • the option is directly passed to cc and thus behaves exactly as it does in the cc crate

Makes ugly workarounds like passing /MD as flags obsolete, which will trigger a warning as this will override the existing /MX flags initially set by the cc crate.

- option is directly passed to cc and thus behaves exactly as it does in the cc crate
@ogoffart
Copy link
Collaborator

Thanks for the patch.
Simple enough.
The CI error is unrelated so i'll merge this anyway.

Note that there is also a From implementation from the cc::Build : https://docs.rs/cpp_build/latest/cpp_build/struct.Config.html#impl-From%3CBuild%3E-for-Config

@ogoffart ogoffart merged commit cc63bb0 into mystor:master Sep 23, 2025
0 of 10 checks passed
@emuell
Copy link
Contributor Author

emuell commented Sep 23, 2025

Missed the From impl. That indeed would also have done the job. Thanks.

It's probably worth adding a "Config::from" constructor, which would make it more obvious in the docs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants