- Socket HAL (linux/bsd): Fix double-free in Socket_destroy() (see #56) #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This may happen when Socket_destroy() is called several times for same Socket. Fixes #56
ajimuralk
added a commit
to Enbala/lib60870
that referenced
this pull request
Sep 29, 2021
This is to hopefull resolve a double-free caused by repeated calls to Socket_destroy() for the same socket. BBased off of this unmerged PR mz-automation#59
ajimuralk
added a commit
to Enbala/lib60870
that referenced
this pull request
Sep 30, 2021
This is to hopefully resolve a double-free caused by repeated calls to Socket_destroy() for the same socket. Based off of this unmerged PR: mz-automation#59
ajimuralk
added a commit
to Enbala/lib60870
that referenced
this pull request
Dec 3, 2023
This is to hopefully resolve a double-free caused by repeated calls to Socket_destroy() for the same socket. Based off of this unmerged PR: mz-automation#59
ajimuralk
added a commit
to Enbala/lib60870
that referenced
this pull request
Dec 8, 2023
* - silenced some VS warnings * - fixed memory leak when CS104_MODE_CONNECTION_IS_REDUNDANCY_GROUP is used together with non thread mode (LIB8705-45)(mz-automation#129) * - fixed compilation problem with configuration option CONFIG_CS104_SUPPORT_SERVER_MODE_MULTIPLE_REDUNDANCY_GROUPS = 0 * - removed redundant declarations * - CS104 server: added lock to protect slave state variables (LIB8705-49) * - CS 101 balanced mode: ignore ACK message when waiting for link status - some code cleanup * - added state locking for CS104_Connection and CS104_Slave * - removed some warnings from Windows PAL * - fixed wrong return value; removed warning - updated version to 2.3.2 * - updated README * - integrated updated TLS code (LIB8705-51) * - integrated TLS test cases (LIB8705-51) * - updated CHANGELOG and README files; make scripts * - fixed TLS examples; removed unused variable * - changed library name in makefiles to match the library names cmake build files * - CS104 client: added new connection event type CS104_CONNECTION_FAILED to better track async connection establishment (LIB8705-33) * - added example for async CS 104 connection establishment * - fixed compilation problems with VC++ * - fixed - CS 101 unbalanced primary link layer parameter problem (mz-automation#122) * - CS101 (balanced mode): always send "Request Status of Link" before sending "Reset of Remote Link" * - CS101 unbalanced master: always send request status of link before reset link; added timeout to delay link status request * - CS 104 connection: call event handler at end of thread when connection is closed or failed to open * - added missing case in CS 104 client examples * - some small code improvements; removed cppcheck warnings * - updated multi_client_server example * - fixed wrong version number returned by Lib60870_getLibraryVersionInfo * - fixed compile error when CONFIG_USE_THREADS = 0 (mz-automation#133) * - fixed - CS104_Connection deadlock when sending commands/ASDUs (mz-automation#134)(LIB8705-52) - CS104_Connection: removed sendASDUsLock and socketWriteLock (no longer required) * - fixed - CS 104 server: invalid read - when MasterConnection_deactivate is called after MasterConnection_deinit (LIB8705-54) - fixed - CS 104 server: connection is closed by server when receiving S message in inactive state (LIB8705-55) * - CS104 slave: fixed - lock not released in error case (mz-automation#138) * - CS104 slave: fixed potential dead lock in CS104_Slave_stop * - added missing API header file (cs101_file_service.h) to install targets * Added Download Link for mbedtls to ReadMe * - CS104 server: increased default max allowed number of clients to 100 * - CS104 client: Call connection handler only from unlocked code to avoid deadlocks in user code (LIB8705-62) * build 64-bit on macOS * always compile with -fPIC * additional datapoints in examples * Ensure socket exists before destroying. This is to hopefully resolve a double-free caused by repeated calls to Socket_destroy() for the same socket. Based off of this unmerged PR: mz-automation#59 * defer the workflow * ignore build dir * Fix filename typo in target_system.mk --------- Co-authored-by: Michael Zillgith <[email protected]> Co-authored-by: Jude Adam Mingay <[email protected]> Co-authored-by: jsackett-ggs <[email protected]> Co-authored-by: Landon Ajimura <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may happen when Socket_destroy() is called several times for same Socket.
Fixes #56