Skip to content

Conversation

@Frando
Copy link
Member

@Frando Frando commented Dec 8, 2025

Description

Our DoH support in iroh-dns-server is broken: #3737

We didn't have any tests for DoH before.

This adds end-to-end tests that test resolving DoH records via HTTP and HTTPS via reqwest, and via hickory-resolver.

While working on this, I realized that we currently do not change the storage path in tests, which is bad can can lead to very unexpected behavior when running tests concurrently. This also fixes that by allowing to pass in the storage path.

Breaking Changes

Notes & open questions

Change checklist

  • Self-review.
  • Documentation updates following the style guide, if relevant.
  • Tests if relevant.
  • All breaking changes documented.
    • List all breaking changes in the above "Breaking Changes" section.
    • Open an issue or PR on any number0 repos that are affected by this breaking change. Give guidance on how the updates should be handled or do the actual updates themselves. The major ones are:

@github-actions
Copy link

github-actions bot commented Dec 8, 2025

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3745/docs/iroh/

Last updated: 2025-12-08T15:14:00Z

@github-actions
Copy link

github-actions bot commented Dec 8, 2025

Netsim report & logs for this PR have been generated and is available at: LOGS
This report will remain available for 3 days.

Last updated for commit: a6f33b8

@n0bot n0bot bot added this to iroh Dec 8, 2025
@github-project-automation github-project-automation bot moved this to 🏗 In progress in iroh Dec 8, 2025
@Frando Frando force-pushed the Frando/dns-server-doh-tests branch from b409644 to b2c1c2d Compare December 8, 2025 15:11
@Frando Frando requested review from dignifiedquire and rklaehn and removed request for dignifiedquire December 8, 2025 15:11
@dignifiedquire
Copy link
Contributor

---- http::tests::test_doh stdout ----

thread 'http::tests::test_doh' (6480) panicked at /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/tracing-subscriber-0.3.22/src/fmt/mod.rs:1247:16:
Unable to install global subscriber: SetGlobalDefaultError("a global default trace dispatcher has already been set")
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

the cross failure seems real

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🏗 In progress

Development

Successfully merging this pull request may close these issues.

3 participants