refactor(iroh)!: make net-report private #3758
Merged
+27
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we no longer use net-report in `iroh-doctor`, so we can make this private now
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3758/docs/iroh/ Last updated: 2025-12-11T01:23:02Z |
flub
approved these changes
Dec 10, 2025
Contributor
flub
left a comment
flub
left a comment
There was a problem hiding this comment.
This was less exciting than the title made me believe. But any reduction in public API makes me happy!
LGTM though I'd adjust some more visibility qualifiers. But that's only my personal style really. The only clippy lint I found, redundant_pub_crate, is in fact entirely the opposite 😬
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We no longer use net-report in
iroh-doctor, so we can make this private now and slim down the public iroh API.Breaking Changes
irohnet_reportmodule is now privateiroh::net_report::Reportis now exported asiroh::NetReportiroh::net_report::Optionsis no longer public (pub(crate)instead)iroh::net_report::QuicConfigis no longer public (pub(crate)instead)