Skip to content

Conversation

@Arqu
Copy link
Collaborator

@Arqu Arqu commented Dec 10, 2025

Description

Fixes #3755

Breaking Changes

Notes & open questions

Change checklist

  • Self-review.
  • Documentation updates following the style guide, if relevant.
  • Tests if relevant.
  • All breaking changes documented.
    • List all breaking changes in the above "Breaking Changes" section.
    • Open an issue or PR on any number0 repos that are affected by this breaking change. Give guidance on how the updates should be handled or do the actual updates themselves. The major ones are:

@Arqu Arqu requested review from dignifiedquire and flub December 10, 2025 10:07
@Arqu Arqu self-assigned this Dec 10, 2025
@Arqu Arqu added this to iroh Dec 10, 2025
@github-project-automation github-project-automation bot moved this to 🏗 In progress in iroh Dec 10, 2025
@github-actions
Copy link

github-actions bot commented Dec 10, 2025

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3759/docs/iroh/

Last updated: 2025-12-10T10:11:34Z

@Arqu Arqu moved this from 🏗 In progress to 👀 In review in iroh Dec 10, 2025
@Arqu Arqu changed the title fix: fix shutdown block fix: shutdown block Dec 10, 2025
@flub
Copy link
Contributor

flub commented Dec 10, 2025

Can you reference the corresponding quinn PR? I think it's best to leave feat-multipath pointing at main-iroh of quinn for now and get the fix merged there first. Otherwise things will get very confusing.

@Arqu
Copy link
Collaborator Author

Arqu commented Dec 10, 2025

This is the quinn PR in question n0-computer/quinn#233
But given the discussion, we can drop it here, bump the timeout to 3.5 sec on the transfer example for now and maybe leave a note and do that one in a follow up.

This also allows us to go back to main-iroh

@flub
Copy link
Contributor

flub commented Dec 10, 2025

so are you updating this to only the moving of where the closing is set and closing the other PR? /me confused on how actionable this is right now.

@Arqu
Copy link
Collaborator Author

Arqu commented Dec 10, 2025

Close in favor of #3762

@Arqu Arqu closed this Dec 10, 2025
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in iroh Dec 10, 2025
@Arqu Arqu deleted the arqu/fix_transfer_shutdown branch December 10, 2025 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants