use PATH_CHALLENGE for hole punching

quinn-proto/proptest-regressions/tests/proptest.txt

@@ -12,3 +12,9 @@ cc 527f2244c8b1fc88c875cc477a77cfc911095c89baf47f8ff23705cd2da04728 # shrinks to
 cc 7c2921e2bb159914227dba332fce2a83931868b19a425e90dd9dd0ae018ec380 # shrinks to input = _RandomInteractionMultipathArgs { seed: [201, 119, 56, 156, 173, 104, 243, 75, 174, 248, 232, 226, 240, 106, 118, 59, 226, 245, 138, 50, 100, 4, 245, 65, 8, 174, 18, 189, 72, 10, 166, 160], interactions: [ClosePath(Server, 0, 0), PathSetStatus(Server, 0, Available), PathSetStatus(Server, 0, Available), Drive(Server), Drive(Server), OpenPath(Client, Backup, 1), ClosePath(Client, 0, 0), Drive(Client), DropInbound(Server), PathSetStatus(Client, 0, Available)] }
 cc 3d5ff86ac3bd84da3518830f018a5133642b262078c048695594f5616d247020 # shrinks to input = _RandomInteractionMultipathArgs { seed: [210, 201, 26, 224, 119, 101, 141, 66, 111, 72, 209, 54, 244, 152, 94, 18, 45, 173, 179, 181, 147, 85, 230, 46, 7, 242, 81, 4, 198, 24, 121, 165], interactions: [ClosePath(Client, 0, 0), OpenPath(Client, Available, 0), Drive(Client), AdvanceTime, ClosePath(Client, 0, 0), Drive(Server), ClosePath(Server, 0, 0), Drive(Client), ForceKeyUpdate(Client), AdvanceTime] }
 cc 215a943c8e60f09ada372087523b8114749a1996482dbe85980397711a13f58d # shrinks to input = _RandomInteractionWithMultipathComplexRoutingArgs { seed: [72, 153, 153, 105, 159, 93, 233, 10, 59, 231, 65, 60, 167, 18, 129, 206, 29, 156, 143, 59, 42, 86, 103, 173, 22, 172, 190, 232, 95, 125, 120, 70], interactions: [Drive(Server), OpenPath(Client, Backup, 0), OpenPath(Client, Backup, 0), Drive(Client), DropInbound(Server), ClosePath(Client, 0, 0)], routes: RoutingTable { client_routes: [([::1]:44433, 0)], server_routes: [([::1]:4433, 0)] } }
+cc 59d6402f86f0f8f34c579483f8002bfe69c025d22eb016ed3667a735fc20938d # shrinks to input = _RandomInteractionWithMultipathComplexRoutingArgs { seed: [195, 220, 29, 198, 108, 228, 72, 30, 208, 159, 207, 61, 137, 60, 226, 135, 49, 183, 17, 117, 215, 78, 207, 182, 37, 152, 245, 59, 124, 101, 172, 229], interactions: [OpenPath(Client, Available, 0), Drive(Client), CloseConn(Client, 0), DropInbound(Server), AdvanceTime, ClosePath(Client, 0, 0), Drive(Server), DropInbound(Client)], routes: RoutingTable { client_routes: [([::1]:44433, 0)], server_routes: [([::1]:4433, 0)] } }
+cc 3d6c441f557c9a532bc87c8a0afdbbd27c39490d07acac53f065c8f086d51868 # shrinks to input = _RandomInteractionWithMultipathComplexRoutingArgs { seed: [198, 210, 21, 57, 34, 221, 110, 4, 146, 10, 168, 56, 237, 139, 15, 230, 62, 175, 3, 36, 5, 64, 169, 44, 210, 92, 112, 1, 164, 152, 59, 30], interactions: [OpenPath(Client, Available, 2), Drive(Client), OpenPath(Client, Available, 0), CloseConn(Server, 0), ClosePath(Client, 0, 0), AdvanceTime, Drive(Client), Drive(Server), DropInbound(Server), DropInbound(Client)], routes: RoutingTable { client_routes: [([::1]:44433, 0)], server_routes: [([::1]:4433, 0), ([::1]:4433, 0), ([::1]:4434, 0)]}}
+cc 4e409ceeb023bc639c6095f657b320a4092f50cfac1430e6a496671717e2d523 # shrinks to input = _RandomInteractionWithMultipathComplexRoutingArgs { seed: [29, 61, 139, 201, 34, 30, 159, 250, 61, 238, 188, 85, 87, 180, 63, 53, 238, 57, 211, 214, 253, 7, 215, 79, 165, 51, 109, 179, 243, 141, 173, 86], interactions: [CloseConn(Server, 0), Drive(Server), DropInbound(Client), DropInbound(Server), Drive(Server), OpenPath(Client, Available, 0), ClosePath(Client, 0, 0), AdvanceTime, Drive(Server)], routes: RoutingTable { client_routes: [([::1]:44433, 0)], server_routes: [([::1]:4433, 0)] } }
+cc 65bf05f654c33cd7c51a20cba759c23876eee689cb4f4f6a58d410a5a895e853 # shrinks to input = _RandomInteractionWithMultipathComplexRoutingArgs { seed: [140, 230, 19, 141, 169, 227, 178, 69, 74, 147, 156, 55, 95, 139, 162, 4, 10, 216, 65, 170, 204, 226, 236, 148, 67, 42, 222, 95, 125, 25, 72, 177], interactions: [OpenPath(Client, Available, 0), ClosePath(Client, 1, 0), Drive(Client), AdvanceTime, Drive(Server), CloseConn(Client, 0), Drive(Client), DropInbound(Server)], routes: RoutingTable { client_routes: [([::1]:44433, 0)], server_routes: [([::1]:4433, 0)] } }
+cc 8097f9984cdf32de70860f9937b634238806f927d9049e0885fa4ce850736677 # shrinks to input = _RandomInteractionWithMultipathComplexRoutingArgs { seed: [107, 155, 165, 131, 109, 32, 159, 34, 208, 118, 134, 109, 75, 210, 123, 192, 194, 129, 67, 62, 178, 22, 70, 40, 248, 190, 76, 30, 220, 90, 56, 211], interactions: [OpenPath(Client, Available, 0), Drive(Server), ClosePath(Client, 1, 0), DropInbound(Server)], routes: RoutingTable { client_routes: [([::1]:44433, 0)], server_routes: [([::1]:4433, 0)] } }
+cc 1564b6bdcfac5091ec82355328cf6ec990238c15e3e18ba8a415f69e291112f8 # shrinks to input = _RandomInteractionWithMultipathComplexRoutingArgs { seed: [238, 126, 150, 148, 168, 209, 105, 125, 53, 117, 5, 135, 177, 42, 115, 17, 218, 246, 104, 20, 44, 90, 242, 68, 129, 206, 15, 97, 145, 16, 226, 228], interactions: [OpenPath(Client, Available, 0), Drive(Client), ClosePath(Client, 1, 0)], routes: RoutingTable { client_routes: [([::1]:44433, 0)], server_routes: [([::1]:4433, 0)] } }

quinn-proto/src/cid_queue.rs

@@ -125,8 +125,6 @@ impl CidQueue {
     ///
     /// If there's no more CIDs in the ready set, this will return None.
     /// CIDs marked as reserved will be skipped when the active one advances.
-    // TODO(@divma): remove
-    #[cfg(test)]
     pub(crate) fn next_reserved(&mut self) -> Option<ConnectionId> {
         let (i, cid_data) = self.iter_from_reserved().nth(1)?;