fix(quinn-proto): prevent O(N^2) behaviour when sending a lot of small values in SendBuffer #247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation to adding a BytesMut at the end
rklaehn
changed the title
rklaehn
commented
Dec 12, 2025
rklaehn
commented
Dec 12, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #247 +/- ##
==========================================
- Coverage 76.66% 76.60% -0.06%
==========================================
Files 83 83
Lines 23347 23432 +85
==========================================
+ Hits 17898 17950 +52
- Misses 5449 5482 +33 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/quinn/pr/247/docs/iroh_quinn/ Last updated: 2025-12-22T14:09:07Z |
rklaehn
force-pushed
the
fix-send-buffer
branch
from
bfe3daa to
0234c4a
Compare
| } | ||
|
|
||
| #[cfg(test)] | ||
| mod tests { |
Collaborator
There was a problem hiding this comment.
I was wondering if we could have some proptests? 😅 they have been very good at making sure things have less bugs
Collaborator
|
Removed myself from review, would love to see this merged but I don't think I have much helpful impact on this. Feel free to re-request if needed. (also, can this be merged yet? 😀 ) |
flub
added
the
performance
rklaehn
force-pushed
the
fix-send-buffer
branch
from
7d9c0e4 to
3f401b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace SendBuffer::get with get_into that scans the entire buffer and copies the relevant range to a &mut impl BufMut.
This turns the O(N*K) when the buffer consists of many tiny slices to O(N).
Also does some refactoring to prepare for a mutable buffer at the end, and renames some variables.
Breaking Changes
None
Notes & open questions
Q: Should we keep the "test" for O(NK) behaviour?
Q: is it ok to panic when misused? Before this would have led to an endless loop.