Skip to content

Conversation

@rklaehn
Copy link

@rklaehn rklaehn commented Dec 12, 2025

Description

Defers the creation of the Bytes a tiny bit more, so we can decide in the SendBufferData to either copy or create a Bytes.

For anything less than MAX_COMBINE, we will not create a Bytes at all.

Breaking Changes

None

Notes & open questions

That way for small writes we don't have to do it!
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 85.88957% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.42%. Comparing base (38a7d15) to head (1b484db).

Files with missing lines Patch % Lines
quinn-proto/src/connection/send_buffer.rs 82.83% 23 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           main-iroh     #252      +/-   ##
=============================================
- Coverage      76.52%   76.42%   -0.11%     
=============================================
  Files             83       83              
  Lines          23018    23110      +92     
=============================================
+ Hits           17615    17662      +47     
- Misses          5403     5448      +45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@n0bot n0bot bot added this to iroh Dec 12, 2025
@github-project-automation github-project-automation bot moved this to 🏗 In progress in iroh Dec 12, 2025
@rklaehn rklaehn changed the base branch from main-iroh to main December 16, 2025 12:34
@rklaehn rklaehn changed the base branch from main to fast-send-buffer-2 December 16, 2025 12:35
@flub flub added the performance Things that might improve performance both for iroh and as a normal QUIC library. label Dec 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

performance Things that might improve performance both for iroh and as a normal QUIC library.

Projects

Status: 🏗 In progress

Development

Successfully merging this pull request may close these issues.

4 participants