-
Notifications
You must be signed in to change notification settings - Fork 4
bench: Allow configuring the runtime type in the bulk bench #280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Also switch the default to the multithreaded runtime. I think that is more representative of actual use.
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/quinn/pr/280/docs/iroh_quinn/ Last updated: 2025-12-19T15:00:26Z |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #280 +/- ##
==========================================
- Coverage 76.69% 76.47% -0.22%
==========================================
Files 83 83
Lines 23241 23352 +111
==========================================
+ Hits 17824 17858 +34
- Misses 5417 5494 +77 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@matheus23 could you review this please? |
| /// The runtime type to use | ||
| #[clap(long, default_value = "tokio")] | ||
| pub runtime_type: RuntimeType, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In iroh-bench I'm doing some very similar changes, can we align on them? There, I allow configuring the amount of worker threads per endpoint.
IMO this is slightly better than configuring all endpoints to have a multi-threaded runtime, since then you'd be putting multiple full-sized tokio runtimes into a single process.
I've added an admittedly somewhat hacky fallback there where setting --workers-per-ep=0 will use the normal multi-threaded runtime.
Description
Allow configuring the runtime type in the bulk bench
Also switch the default to the multithreaded runtime. I think that is more representative of actual use.
I mostly need this to compare the two runtimes. Currently the current thread runtime is faster, which is very unintuitive, since we are doing absolutely everything on one thread, send, recv, encrypt, decrypt.
Breaking Changes
None
Notes & open questions