fix(proto): Use path PTOs for PATH_ABANDON calculations #291
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This changes the PTO calculations for the deadline by which we expect PATH_ABANDONs to arrive as well as when we can discard a path.
Concretely:
Waiting 3 * PTO for a response on a particular path is pretty standard procedure, so this makes sense for PATH_ABANDON as well. By moving the code to where the PATH_ABANDON is actually sent we make sure that we know which path the PATH_ABANDON is sent on.
Waiting 3 * PTO to discard the path state is similar to the time that's used for draining connections: This is the best effort at making sure there's no more stray datagrams flying around.
We still avoid setting a time for an expected PATH_ABANDON receive, because that timer might fire incorrectly when the path was abandoned just before the connection severs. We don't know if the peer actually ignored it, or if it's due to packet loss.