Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update terraform-docs settings and checkout ref #23

Merged
merged 1 commit into from
Mar 3, 2024
Merged

Update terraform-docs settings and checkout ref #23

merged 1 commit into from
Mar 3, 2024

Conversation

jonathanio
Copy link
Contributor

Update the default settings for terraform-docs, emptying the settings for output-method and template, otherwise these are overridden on the command-line by the Action and the .terraform-docs.yaml configuration file provided is ignored.

Also, update the checkout Action with the reference for the checkout so that the git-push for terraform-docs will work again.

Checklist

Please confirm the following checks:

  • My pull request follows the guidelines set out in CONTRIBUTING.md.
  • I have performed a self-review of my code and run any tests locally to check.
  • I have added tests that prove my changes are effective and work correctly.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my code and corrected any misspellings.
  • Each commit in this pull request has a meaningful subject & body for context.
  • I have squashed all "fix(up)" commits to provide a clean code history.
  • My pull request has an appropriate title and description for context.
  • I have linked this pull request to other issues or pull requests as needed.
  • I have added type/..., changes/..., and 'release/...' labels as needed.

@jonathanio
Update terraform-docs settings and checkout ref
6068ba7 
Update the default settings for terraform-docs, emptying the settings
for output-method and template, otherwise these are overridden on the
command-line by the Action and the .terraform-docs.yaml configuration
file provided is ignored.

Also update the checkout Action with the reference for the checkout so
that the git-push for terraform-docs will work again.
@jonathanio jonathanio added priority/normal This is a normal-priority issue or pull request release/update An update to an existing feature is made with this pull request type/bug Something is not working correctly update/github-workflows Update with changes to GitHub Workflows labels Mar 3, 2024
@jonathanio jonathanio self-assigned this Mar 3, 2024
@jonathanio jonathanio merged commit 7a3442a into main Mar 3, 2024
4 of 7 checks passed
@jonathanio jonathanio deleted the update-terraform-docs-settings branch March 3, 2024 16:20
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jonathanio jonathanio

Labels
priority/normal This is a normal-priority issue or pull request release/update An update to an existing feature is made with this pull request type/bug Something is not working correctly update/github-workflows Update with changes to GitHub Workflows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jonathanio