Restore non-App Store support for Slack #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A previous commit added support for when Slack is installed through the App Store. Alas, it broke support for non-App Store situations! This commit restores non- App Store support, while retaining the support for App Store scenarios.
|
Sweet, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I don't know what I was smoking in #69 . While that PR added support for when Slack is installed through the App Store, it broke support for non-App Store situations! This PR restores non- App Store support, while retaining the support for App Store scenarios.
Status
READY
Related Issues
Todos
Steps to Test or Reproduce
Try on MacOS where Slack is installed via direct download (DMG) rather than through the App Store.
Other notes
None