Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Baserow Node): Add uploading files & trigger node #10219

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

cedricziel
Copy link

@cedricziel cedricziel commented Jul 28, 2024

Summary

This PR adds:

  • Support for uploading files (via binary & url)
  • Testing for all the nodes
  • A baserow trigger-node

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

Screenshots

Result of a trigger node:

image

File upload via binary:

image

File Upload via url

image

@CLAassistant
Copy link

CLAassistant commented Jul 28, 2024

CLA assistant check
All committers have signed the CLA.

@n8n-assistant n8n-assistant bot added community Authored by a community member node/improvement New feature or request in linear Issue or PR has been created in Linear for internal review labels Jul 28, 2024
@cedricziel cedricziel changed the title WIP feat(baserow): upload files via url feat(baserow): upload files via url Dec 4, 2024
@cedricziel cedricziel changed the title feat(baserow): upload files via url feat(baserow): upload files Dec 4, 2024
@cedricziel cedricziel marked this pull request as ready for review December 4, 2024 21:02
@Joffcom
Copy link
Member

Joffcom commented Dec 5, 2024

Hey @cedricziel,

Looking at the change it looks ok although you have updated the json file version whcih isn't needed, If you can revert that and add some tests for the new functionality we should eb able to get this merged.

I will fix the PR title so it falls in line with our conventions.

@Joffcom Joffcom changed the title feat(baserow): upload files feat(baserow Node): Add support for uploading files Dec 5, 2024
@Joffcom Joffcom changed the title feat(baserow Node): Add support for uploading files feat(Baserow Node): Add support for uploading files Dec 5, 2024
@cedricziel
Copy link
Author

@Joffcom I'm struggling setting up some tests but I made the version change

@cedricziel cedricziel changed the title feat(Baserow Node): Add support for uploading files WIP feat(Baserow Node): Add support for uploading files Dec 6, 2024
@cedricziel cedricziel changed the title WIP feat(Baserow Node): Add support for uploading files feat(Baserow Node): Add uploading files & trigger node Dec 11, 2024
@cedricziel
Copy link
Author

@Joffcom the scope here has changed, can you give it a review please?

@Joffcom
Copy link
Member

Joffcom commented Dec 16, 2024

Hey @cedricziel,

Because the scope has changed so much and includes a new node we will not be accept this PR in it's current state. Ideally PRs should be kept small, We are also not adding new community nodes which means the trigger node you have created will need to be published to NPM.

@cedricziel
Copy link
Author

@Joffcom sorry, i am trying to understand how to proceed here.

First of all thanks for letting me know - 2nd of all does that mean I'm supposed to publish new nodes to npm in a self-contained fashion?

Is that documented somewhere?

I'm a bit flabbergasted; how are you adding new services?

@cedricziel
Copy link
Author

@Joffcom I removed the trigger node as per our chat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Authored by a community member in linear Issue or PR has been created in Linear for internal review node/improvement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants