fix(createVectorStoreNode): Prevent connection leaks in PGVectorStore… #12408
Conversation
|
|
n8n-assistant
bot
added
community
|
Hey @lchavezpozo, Thanks for the PR, We have created "GHC-614" as the internal reference to get this reviewed. One of us will be in touch if there are any changes needed, in most cases this is normally within a couple of weeks but it depends on the current workload of the team. |
| @@ -395,7 +396,14 @@ export const createVectorStoreNode = (args: VectorStoreNodeConstructorArgs) => | |||
|
|
|||
| if (mode === 'retrieve') { | |||
| const vectorStore = await args.getVectorStoreClient(this, filter, embeddings, itemIndex); | |||
|
|
|||
| async function closeFunction() { | |||
There was a problem hiding this comment.
Can you revert the changes to this file, and merge back the latest master?
I think the closeFunction removal in the other file is all that's needed now after #12346
There was a problem hiding this comment.
If I don’t include this change, PGVectorStore will also increase the connections to Postgres. I couldn’t find a cleaner way to apply this adjustment. I ran tests by removing closeFunction, but the connections still increased.”
Summary
This PR fixes an issue related to connection pool management in the PostgreSQL pool of the VectorStorePGVector node. It was identified that connections were not being properly released, leading to connection leaks and eventually blocking access to PostgreSQL.
Related Linear tickets, Github issues, and Community forum posts
https://community.n8n.io/t/postgres-connection-error-sorry-too-many-clients-already/63473/1
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)