fix(editor): Show all workflows in the error workflow dropdown in the workflow settings #12413
+31
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… workflow settings
n8n-assistant
bot
added
n8n team
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
mutdmour
approved these changes
Jan 3, 2025
|
|
n8n
|
||||||||||||||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
pay-2073-bug-any-workflow-sub-workflow-setting-broken-by-projects
|
| Run status |
|
| Run duration | 04m 07s |
| Commit |
|
| Committer | Danny Martini |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
1
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
298
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
14-mapping.cy.ts • 1 failed test
| Test | Artifacts | |
|---|---|---|
| Data mapping > maps expressions from table header |
Test Replay
Screenshots
Video
|
|
The first 5 failed specs are shown, see all 48 specs in Cypress Cloud.
e2e/14-mapping.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Data mapping > maps expressions from json view |
Test Replay
Screenshots
Video
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The error worfklow dropdown is just a special case of calling a sub workflow and should render the same list the sub workflow node is rendering:
Before:
After:
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/PAY-2073/bug-any-workflow-sub-workflow-setting-broken-by-projects
Review / Merge checklist
Docs updated or follow-up ticket created.PR Labeled withrelease/backport(if the PR is an urgent fix that needs to be backported)