Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Run workflow if active and single webhook service has pin data #12425

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

michael-radency
Copy link
Contributor

Summary

Allow to test webhook with services that only allow to register one single Webhook and has pinned data

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-2127/bug-cannot-execute-telegram-node-even-though-its-pinned

@michael-radency michael-radency added ui Enhancement in /editor-ui or /design-system n8n team Authored by the n8n team node/issue Issue with a node labels Jan 2, 2025
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ckages/editor-ui/src/composables/useRunWorkflow.ts 80.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Contributor

@ShireenMissi ShireenMissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Copy link
Contributor

github-actions bot commented Jan 3, 2025

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link

cypress bot commented Jan 3, 2025

n8n    Run #8575

Run Properties:  status check failed Failed #8575  •  git commit fe2152b46f: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 michael-radency 🗃️ e2e/*
Project n8n
Branch Review node-2127-bug-cannot-execute-telegram-node-even-though-its-pinned
Run status status check failed Failed #8575
Run duration 36m 29s
Commit git commit fe2152b46f: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 michael-radency 🗃️ e2e/*
Committer Michael Kret
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 281
View all changes introduced in this branch ↗︎

Tests for review

Failed  45-workflow-selector-parameter.cy.ts • 1 failed test

View Output Video

Test Artifacts
Workflow Selector Parameter > should render add resource option and redirect to the correct route when clicked Test Replay Screenshots Video
Failed  25-stickies.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  30-editor-after-route-changes.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  14-mapping.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  6-code-node.cy.ts • 0 failed tests

View Output

Test Artifacts

The first 5 failed specs are shown, see all 51 specs in Cypress Cloud.

@ShireenMissi ShireenMissi force-pushed the node-2127-bug-cannot-execute-telegram-node-even-though-its-pinned branch from 432ebd9 to fe2152b Compare January 3, 2025 17:38
Copy link
Contributor

github-actions bot commented Jan 3, 2025

⚠️ Some Cypress E2E specs are failing, please fix them before merging

1 similar comment
Copy link
Contributor

github-actions bot commented Jan 5, 2025

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/issue Issue with a node ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants