-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(editor): Fix Multi option parameter expression when the value is an array #12430
Open
ShireenMissi
wants to merge
3
commits into
master
Choose a base branch
from
node-1535-multi-options-component-dont-show-error-when-using-array-in-expression
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix(editor): Fix Multi option parameter expression when the value is an array #12430
ShireenMissi
wants to merge
3
commits into
master
from
node-1535-multi-options-component-dont-show-error-when-using-array-in-expression
+8
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
n8n team
Authored by the n8n team
ui
Enhancement in /editor-ui or /design-system
labels
Jan 2, 2025
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
@ShireenMissi I would say this change should be scoped to multi-options input, now it would affect all inputs, that could cause some regressions |
ShireenMissi
force-pushed
the
node-1535-multi-options-component-dont-show-error-when-using-array-in-expression
branch
from
January 3, 2025 14:45
ec14da6
to
f5ad7d1
Compare
michael-radency
approved these changes
Jan 3, 2025
|
ShireenMissi
force-pushed
the
node-1535-multi-options-component-dont-show-error-when-using-array-in-expression
branch
from
January 3, 2025 16:47
4d4dbaa
to
7952f9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
n8n team
Authored by the n8n team
tests-needed
This PR needs additional tests
ui
Enhancement in /editor-ui or /design-system
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In multi option parameters, the array is an acceptable value for expressions
This PR:
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/NODE-1535/multi-options-component-dont-show-error-when-using-array-in-expression
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)