fix(core): Only show personal credentials in the personal space #12433
+13
−31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently if an owner or admin look at the personal space they see all credentials they have access to, not just the personal ones:
The reason for that is a previous fix: #9396
If a user with the global
credential:list
makes the request and passes the queryincludeScopes:true
the project filter would be ignored. That was done because the endpoint was also used to get the credentials that can be used in a node and the differentiating factor was theincludeScopes
parameter.Since then we created a new API endpoint for fetching credentials that can be used in a node/worfklow and thus don't need this hack anymore: #9718
Now when we remove this hack we get the anticipated result:
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/PAY-2422/credentials-in-personal-list-showing-all-credentials-i-have-access-to
Review / Merge checklist
Docs updated or follow-up ticket created.PR Labeled withrelease/backport
(if the PR is an urgent fix that needs to be backported)