Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Only show personal credentials in the personal space #12433

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

despairblue
Copy link
Contributor

@despairblue despairblue commented Jan 2, 2025

Summary

Currently if an owner or admin look at the personal space they see all credentials they have access to, not just the personal ones:

image

The reason for that is a previous fix: #9396

If a user with the global credential:list makes the request and passes the query includeScopes:true the project filter would be ignored. That was done because the endpoint was also used to get the credentials that can be used in a node and the differentiating factor was the includeScopes parameter.

image

Since then we created a new API endpoint for fetching credentials that can be used in a node/worfklow and thus don't need this hack anymore: #9718

Now when we remove this hack we get the anticipated result:

image

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/PAY-2422/credentials-in-personal-list-showing-all-credentials-i-have-access-to

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@despairblue despairblue marked this pull request as ready for review January 2, 2025 14:14
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Jan 2, 2025
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant