Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Fix '=' handling in expressions #13129

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

elsmr
Copy link
Member

@elsmr elsmr commented Feb 7, 2025

Summary

  • Typing = in a fixed input should switch to expressions
  • Fix: Typing = in a expression input should insert a = (should not disappear in any case)
  • New: Typing Backspace in an empty expression input switches back to fixed
  • Fix: auto bracket closing should overwrite manually typed closing brackets (instead of duplicating)
  • Cleanup unused code
Screen.Recording.2025-02-07.at.15.27.45.mov

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-2176/community-issue-google-sheet-node-removes-the-=-for-formulas
fixes #12194

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

Copy link

codecov bot commented Feb 7, 2025

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Feb 7, 2025
Copy link
Contributor

@ShireenMissi ShireenMissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested manually and it all works as expected except for closing brackets see the screen recording

Screen.Recording.2025-02-07.at.17.03.11.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Google Sheet Node removes the "=" for formulas
2 participants