-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): equals sign breaks the "Import from cURL" functionality for HTTP node #9769
base: master
Are you sure you want to change the base?
Conversation
Fix equal sign encoding in "Import from cURL" feature. n8n-io#9768
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I can tell curlconverter@4 is an ESM only package, and n8n can't use ESM right now.
To solve this we either need to update n8n, and all its dependencies to be ESM, or ask curlconverter to publish a package that works with CJS and ESM both.
The third option would be find the actual fix in curlconverter@4, back-port it to 3.x, send them a PR, ask them to publish a 3.x version, and then update that version here.
Tracking: https://linear.app/n8n/issue/PAY-1681 |
It turned out that the problem is in query-string package which is used in this is where the string gets corrupted. I can get the latest version of this |
Do you mean back-port the fix in curlconverter? I think that's the decision for the maintainers of curlconverter. |
Summary
"Import from cURL" functionality for HTTP node is broken for some POSTed JSON data.
=
sign is encoded incorrectly on JSON import due to outdatedcurlconverter
dependency. I verified that newercurlconverter
versions are working correctly. (I am new to n8n development so I apologize if I missed something in this PR)Related Linear tickets, Github issues, and Community forum posts
#9768