Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(core): Accelerate common execution queries #9817

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

perf(core): Accelerate common execution queries #9817

wants to merge 7 commits into from
+123 −9

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Jun 20, 2024 •
edited
Loading

@ivov ivov changed the title perf(core): Speed up common execution queries perf(core): Accelerate common execution queries Jun 20, 2024
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Jun 20, 2024
@ivov ivov marked this pull request as ready for review June 20, 2024 13:23
@ivov ivov requested a review from a team as a code owner June 20, 2024 13:23
krynble
krynble reviewed Jun 24, 2024
View reviewed changes
Copy link
Contributor

@krynble krynble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way I see it is that we just need 4 indices, and the image below outlines the changes I'm proposing:

Screenshot 2024-06-24 at 10 22 50

The reason for each index has been described in the ticket, but in the end we want all 4 db systems to have only those 4 indices, wdyt?

packages/cli/src/databases/migrations/common/1717498465932-RefactorExecutionIndices.ts Outdated

if (isSqlite) {
await schemaBuilder.dropIndex('execution_entity', ['stoppedAt'], {
customIndexName: 'idx_execution_entity_stopped_at', // duplicate of `IDX_execution_entity_stoppedAt`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can probably remove both right? Not just the duplicate but both, as these are not used by any query

@ivov
Copy link
Contributor Author

ivov commented Jun 24, 2024

Thanks, from the story I was under the impression we only wanted to touch these, rather than all of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krynble krynble krynble left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ivov @krynble