Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Copper Node): Add to HTTP Request node + Add connection test #9837

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jvdweerthof
Copy link

@jvdweerthof jvdweerthof commented Jun 22, 2024

Summary

  • Add Copper credentials to HTTP Request node
  • Add connection test for Copper credentials
  • Use new authentication method in Copper Node
  • Update the deprecated API endpoint url
Credentials in HTTP Request Node Credential Test Fail Credential Test Success

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added community Authored by a community member node/improvement New feature or request in linear Issue or PR has been created in Linear for internal review labels Jun 22, 2024
@Joffcom
Copy link
Member

Joffcom commented Jun 22, 2024

Hey @jvdweerthof,

Thanks for the PR, Are you also going to update the node to use the new authenticate method?

Typically when making this change the node would also need to be updated.

@jvdweerthof
Copy link
Author

Hi @Joffcom,

I thought for my first PR to n8n I would keep the scope small... :-) But your question makes sense and I guess is in scope.

I updated the node to use the new authentication method, the PR is already updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Authored by a community member in linear Issue or PR has been created in Linear for internal review node/improvement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants