Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(SeaTable Node): Refactor, add new triggers and actions #9856

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

feat(SeaTable Node): Refactor, add new triggers and actions #9856

wants to merge 24 commits into from
+4,054 −565

Conversation

christophdb
Copy link

Complete rework of the SeaTable Node.

  • Adding two new triggers and 12 new actions.
  • Actions use now versioning
  • cleaner code structure
  • already published and tested as community node (n8n-nodes-seatable)

christophdb and others added 17 commits October 26, 2023 02:20
@christophdb
rework of seatable-n8n-node
e791055
@christophdb
bugfix wrong uploadurl for images/files
f4e9995
@christophdb
added missing loadOptionsDependsOn for update a row action
bda3edb
@christophdb
add new action "get many rows"
4f8be47
@christophdb
add case insensitive search to "search" action
0359405
@christophdb
fix "Make an API call"
9765219
@christophdb
improved "upload asset":
95b66a0 
- input workspace_id is not required anymore
- two new options: `Replace existing file` and `Append to column`
@Joffcom
Merge branch 'master' of github.com:n8n-io/n8n into seatable_node_rework
aab002c
@Joffcom
Lint fix on trigger node
5f4ada4
@Joffcom
Fix breaking change that resulted in the old v1 node from appearing
787f33d
@christophdb
supporting big data backend with links and row create, update and delete
5198fda
@christophdb
take over change from Jeffcom
1cc1926
@christophdb
Fix error in upload action, if server domain ends with /
871c24a
@christophdb
fixing asset upload
6f41c75
@christophdb
fixed linter errors and new action get row links
3b0325a
@christophdb
Merge branch 'master' of github.com:seatable/n8n into seatable_node_r…
80fc892 
…ework
@christophdb
Merge branch 'seatable_node_rework'
8e07704
@Joffcom
Copy link
Member

Joffcom commented Jun 25, 2024

Cheers @christophdb

@Joffcom Joffcom self-requested a review June 25, 2024 09:47
@christophdb christophdb mentioned this pull request Jun 25, 2024
Closed
@Joffcom Joffcom changed the title Seatable node rework feat(Seatable Node): Update to include new options Jun 25, 2024
@christophdb christophdb changed the title feat(Seatable Node): Update to include new options refactor(Seatable Node): Refactor, new triggers and actions. Jun 25, 2024
@Joffcom
Copy link
Member

Joffcom commented Jun 25, 2024

@christophdb Looks like there is still a lint issue that needs to be resolved, It may be worth removing some of the comments that are not needed as well.

@n8n-assistant n8n-assistant bot added community Authored by a community member node/improvement New feature or request node/new Creation of an entirely new node in linear Issue or PR has been created in Linear for internal review labels Jun 25, 2024
@christophdb
Copy link
Author

@Joffcom thanks for the hint. I removed unnecessary comments and fixed the lint issue.

@christophdb
Copy link
Author

@Joffcom I am sorry, that my PR still had some issues. These "type check errors" were not raised by my VS Code. Now they should be fixed. Can you please try again? Thanks

@Joffcom
Copy link
Member

Joffcom commented Jun 26, 2024

Hey @christophdb,

It looks like it is still reporting a bunch of lint issues, I have this pencilled in for review tomorrow morning.

@netroy netroy changed the title refactor(Seatable Node): Refactor, new triggers and actions. feat(Seatable Node): Refactor, add new triggers and actions Jun 26, 2024
@netroy
Copy link
Member

netroy commented Jun 26, 2024

I wanted to help fix this up, but unfortunately this PR is not editable by maintainers.
Can you please cherry-pick the last commits from here, so that we can get the review started on this 🙏🏽

@netroy
Copy link
Member

netroy commented Jun 26, 2024

For any future PRs please leave this checkbox enabled 🙏🏽
image

So that we can work with your PRs
image

@christophdb
Copy link
Author

christophdb commented Jun 27, 2024 •
edited
Loading

@netroy: I cherry-picked the commits. Please tell me if I can do something else.
There were conflict in some files. I accepted the changes from master branch.

@netroy netroy changed the title feat(Seatable Node): Refactor, add new triggers and actions feat(SeaTable Node): Refactor, add new triggers and actions Jun 27, 2024
@Joffcom
Copy link
Member

Joffcom commented Jun 27, 2024

Overall I am happy with this, I will need to update our documentation when we merge this but I would like to take a moment to thank you @christophdb for taking on the work of making sure we are using the latest and greatest options that Seatable has to offer.

@janober
Copy link
Member

janober commented Jun 27, 2024

Thanks a lot, @christophdb and @Joffcom, for getting it done!

@MehrCurry
Copy link

I am more than happy that this MR came back to life. A big thanks to all who made it possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Joffcom Joffcom Awaiting requested review from Joffcom

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
community Authored by a community member in linear Issue or PR has been created in Linear for internal review node/improvement New feature or request node/new Creation of an entirely new node
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@christophdb @Joffcom @netroy @janober @MehrCurry