feat(editor): Remove Segment #9878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
n8n team
mutdmour
changed the title
mutdmour
changed the title
mutdmour
commented
Jun 27, 2024
| @@ -34,474 +10,4 @@ export const n8nCloudHooks: PartialDeep<ExternalHooks> = { | |||
| }, | |||
| ], | |||
There was a problem hiding this comment.
keeping this here since we agreed to keep external hooks and deprecate in v2
https://n8nio.slack.com/archives/C03594NKD7W/p1719481324464849
There was a problem hiding this comment.
Maybe add a @deprecated notice and mention that these are being deprecated in v2
mutdmour
changed the title
tomi
approved these changes
Jun 28, 2024
| @@ -34,474 +10,4 @@ export const n8nCloudHooks: PartialDeep<ExternalHooks> = { | |||
| }, | |||
| ], | |||
There was a problem hiding this comment.
Maybe add a @deprecated notice and mention that these are being deprecated in v2
4 flaky tests on run #5705 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Screenshots
Video
|
|
| NDV > Stop listening for trigger event from NDV |
Screenshots
Video
|
|
10-undo-redo.cy.ts • 2 flaky tests
| Test | Artifacts | |
|---|---|---|
| Undo/Redo > should undo/redo adding connected nodes |
Test Replay
Screenshots
Video
|
|
| Undo/Redo > should undo/redo renaming node using NDV |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #9878 ↗︎
|
✅ All Cypress E2E specs passed |
|
@tomi the deprecation is not decided yet. Would handle that separately once we have agreed with Product on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove Segment. Only enabled when Segment library is injected on Cloud
Related Linear tickets, Github issues, and Community forum posts
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)