Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip cleanup synchronizers #1

Open
wants to merge 3 commits into
base: feature/aws-dynamic-account
Choose a base branch
from

Conversation

nimakaviani
Copy link

made the following changes

  • removed DefaultAmazonAccountsSynchronizer
  • removed AmazonAccountsSynchronizer
  • Account loading is now done using AmazonBasicCredentialsLoader and other dependencies are relaxed
  • CredentialsLoader can also be removed but ECS provider depends on it

@nimakaviani
Copy link
Author

I will have an attempt in completely removing CredentialsLoader in a next PR

@nabuskey nabuskey force-pushed the feature/aws-dynamic-account branch 2 times, most recently from 4c92048 to 2d78f5b Compare October 7, 2020 17:06
@nabuskey nabuskey force-pushed the feature/aws-dynamic-account branch 2 times, most recently from 6266ddf to 3da6d8b Compare October 12, 2020 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants