Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

支持contextPath为空 #75

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

netfoxor
Copy link
Contributor

const configClient = new NacosConfigClient({
serverAddr: '127.0.0.1:8848',
contextPath: '',
});
在使用NacosConfigClient时指定了contextPath为空字符串但还是不生效,通过跟踪代码,发现在调http_agent中如果contenxPath为空,会再设置一次默认值,在new NacosConfigClient()时已经处理过一次(如果contextPath不存在则使用默认值'nacos'),所以我的理解这一步应该不需要了,也要考虑有些服务端进行改造时把contextPath去掉的情况。

许昆鹏 and others added 3 commits January 21, 2021 21:21
const configClient = new NacosConfigClient({
  serverAddr: '127.0.0.1:8848',
  contextPath: '',
});
在使用NacosConfigClient时指定了contextPath但还是不生效,通过跟踪代码,发现在调http_agent中如果contenxPath为空,会再设置一次默认值,在创建NacosConfigClient时已经处理过一次(如果contextPath不存在则使用默认值'nacos'),所以我的理解这一步应该不需要了,也要考虑有些服务端进行改造时把contextPath去掉的情况。
@CLAassistant
Copy link

CLAassistant commented Oct 23, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ 许昆鹏
❌ netfoxor


许昆鹏 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants