Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild the structure of openapi #70

Merged
merged 5 commits into from
May 8, 2024

Conversation

Freedomfirebody
Copy link
Contributor

重新调整 openapi 相关接口的代码结构,接口现迁移至 openapi 目录下
PR 对应问题单#62

@CLAassistant
Copy link

CLAassistant commented May 2, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ Freedomfirebody
❌ Cheng Weiss


Cheng Weiss seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@heqingpan
Copy link
Collaborator

需要处理cargo clippy的报警后再合并到master

@Freedomfirebody
Copy link
Contributor Author

已处理 cargo clippy 的 warning 并 执行了 cargo fmt

@heqingpan
Copy link
Collaborator

用项目自带的测试脚本./test_cluster.sh start_debug运行结果还有问题,需要处理下。

1. modify web::resource("/") to web::resource("")
2. change web::scope("/") to vec![ scope ] solution
@Freedomfirebody
Copy link
Contributor Author

已调调整代码问题,测试脚本执行通过
image

@heqingpan
Copy link
Collaborator

上面有个nacos社区统一加的license/cla协议,需要签署下才能合并。

.route(web::post().to(crate::config::api::add_config))
.route(web::put().to(crate::config::api::add_config))
.route(web::delete().to(crate::config::api::del_config)),
.route(web::get().to(crate::openapi::config::api::get_config))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这部分等重构的新控制台上线后就可能去掉。

@heqingpan heqingpan merged commit e657f14 into nacos-group:master May 8, 2024
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants