Skip to content

Commit

Permalink
fix Werror=nonnull in close_command_file
Browse files Browse the repository at this point in the history
add check if fp is not NULL because of:

```
[   92s] In function 'close_command_file',
[   92s]     inlined from 'close_command_file' at src/naemon/commands.c:171:5:
[   92s] src/naemon/commands.c:186:9: error: argument 1 null where non-null expected [-Werror=nonnull]
[   92s]   186 |         fclose(command_file_fp);
[   92s]       |         ^~~~~~~~~~~~~~~~~~~~~~~
[   92s] In file included from src/naemon/objects_host.h:8,
[   92s]                  from src/naemon/comments.h:9,
[   92s]                  from src/naemon/commands.c:3:
[   92s] /usr/include/stdio.h: In function 'close_command_file':
[   92s] /usr/include/stdio.h:183:12: note: in a call to function 'fclose' declared 'nonnull'
[   92s]   183 | extern int fclose (FILE *__stream) __nonnull ((1));
[   92s]       |            ^~~~~~
[   93s] cc1: all warnings being treated as errors
```

Signed-off-by: Sven Nierlein <[email protected]>
  • Loading branch information
sni committed May 22, 2023
1 parent cb8612c commit 192f25c
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/naemon/commands.c
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,8 @@ int close_command_file(void)
command_file_created = FALSE;

/* close the command file */
fclose(command_file_fp);
if (command_file_fp != NULL)
fclose(command_file_fp);

return OK;
}
Expand Down

0 comments on commit 192f25c

Please sign in to comment.